From: Ferruh Yigit <ferruh.yigit@intel.com>
To: oulijun <oulijun@huawei.com>, thomas@monjalon.net
Cc: dev@dpdk.org, linuxarm@openeuler.org
Subject: Re: [dpdk-dev] [PATCH 14/14] net/hns3: support LSC event report
Date: Tue, 2 Feb 2021 12:06:45 +0000 [thread overview]
Message-ID: <156f4d8c-c8f9-f9b3-6ddd-8373c43b2721@intel.com> (raw)
In-Reply-To: <7638a4d0-fb62-131f-1e8c-f5945706b924@huawei.com>
On 1/29/2021 1:49 AM, oulijun wrote:
>
>
> 在 2021/1/29 7:41, Ferruh Yigit 写道:
>> On 1/22/2021 10:18 AM, Lijun Ou wrote:
>>> From: Chengwen Feng <fengchengwen@huawei.com>
>>>
>>> This patch support LSC(Link Status Change) event report.
>>
>> There is a user config for lsc, 'dev->data->dev_conf.intr_conf.lsc', which
>> seems not taken into account.
>>
> Frist of all, thank you for your review. Currently, the old firmware doest not
> support interrupt reporting. Therefore, the PF does not suport interrupt
> reporting through the mailbox. Therefore, the PF obtains interrupts in polling
> mode and then reports interrupts.
>
>
>> Also 'RTE_PCI_DRV_INTR_LSC' should be set in 'rte_pci_driver.drv_flags' to
>> report this feature to higher levels.
>>
> In the future, the new firmware + PF will support interrupt reporting. In that
> case, the LSC capability of dev_flag will be set.
> In the future, we will enable the VF to support LSC. That is, we are developing
> the PF to report LSC interrupts through the mailbox.
>> And when the feature is fully implemented, can you please add "Link status
>> event" feature to 'hns3.ini'?
>>
> By then, we'll add it in hns3.ini.
Got it, so for now only LSC event report (even callbacks call) support added, I
am proceeding with the patch.
>>>
>>> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
>>> Signed-off-by: Lijun Ou <oulijun@huawei.com>
>>
>> <...>
>> .
>>
next prev parent reply other threads:[~2021-02-02 12:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 10:18 [dpdk-dev] [PATCH 00/14] Misc updates for hns3 Lijun Ou
2021-01-22 10:18 ` [dpdk-dev] [PATCH 01/14] net/hns3: encapsulate dfx stats in Rx/Tx datapatch Lijun Ou
2021-01-22 10:18 ` [dpdk-dev] [PATCH 02/14] net/hns3: move queue stats to xstats Lijun Ou
2021-01-22 10:18 ` [dpdk-dev] [PATCH 03/14] net/hns3: use array instead of switch-case Lijun Ou
2021-01-22 10:18 ` [dpdk-dev] [PATCH 04/14] net/hns3: move judgment conditions to separated functions Lijun Ou
2021-01-22 10:18 ` [dpdk-dev] [PATCH 05/14] net/hns3: reconstruct the Rx interrupt map Lijun Ou
2021-01-22 10:18 ` [dpdk-dev] [PATCH 06/14] net/hns3: extract common judgments for all FDIR type Lijun Ou
2021-01-22 10:18 ` [dpdk-dev] [PATCH 07/14] net/hns3: refactor reset event report function Lijun Ou
2021-01-22 10:18 ` [dpdk-dev] [PATCH 08/14] net/hns3: fix memory leak with secondary process exit Lijun Ou
2021-01-22 10:18 ` [dpdk-dev] [PATCH 09/14] net/hns3: fix interrupt resources in Rx interrupt mode Lijun Ou
2021-01-22 10:18 ` [dpdk-dev] [PATCH 10/14] net/hns3: rename RSS functions Lijun Ou
2021-01-22 10:18 ` [dpdk-dev] [PATCH 11/14] net/hns3: adjust some comments Lijun Ou
2021-01-22 10:18 ` [dpdk-dev] [PATCH 12/14] net/hns3: remove unnecessary parentheses Lijun Ou
2021-01-22 10:18 ` [dpdk-dev] [PATCH 13/14] net/hns3: use %d instead of %u for enum variable Lijun Ou
2021-01-22 10:18 ` [dpdk-dev] [PATCH 14/14] net/hns3: support LSC event report Lijun Ou
2021-01-28 23:41 ` Ferruh Yigit
2021-01-29 1:49 ` oulijun
2021-02-02 12:06 ` Ferruh Yigit [this message]
2021-02-02 12:12 ` Ferruh Yigit
2021-01-28 23:58 ` [dpdk-dev] [PATCH 00/14] Misc updates for hns3 Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=156f4d8c-c8f9-f9b3-6ddd-8373c43b2721@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=linuxarm@openeuler.org \
--cc=oulijun@huawei.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).