From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B5720A052A; Tue, 2 Feb 2021 13:06:54 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 32365240270; Tue, 2 Feb 2021 13:06:54 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 2CAA1240253 for ; Tue, 2 Feb 2021 13:06:51 +0100 (CET) IronPort-SDR: LASrmRquAul9By1prGuyw5bhKLdyxUA2lBFAWh99rA1MrAHA3MZ7312voYUYAGMYj/+NmuI9fr Z9rIDCN4r81Q== X-IronPort-AV: E=McAfee;i="6000,8403,9882"; a="177333281" X-IronPort-AV: E=Sophos;i="5.79,394,1602572400"; d="scan'208";a="177333281" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2021 04:06:50 -0800 IronPort-SDR: P1z7ROz7S5EJBeuuLbQWtp1anbS1pWcdExep1ypWNilA3BJRc0XHZSt9S9wV39JIIrMbKndfek 5cle7W6MkGlg== X-IronPort-AV: E=Sophos;i="5.79,394,1602572400"; d="scan'208";a="391437979" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.226.112]) ([10.213.226.112]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2021 04:06:49 -0800 To: oulijun , thomas@monjalon.net Cc: dev@dpdk.org, linuxarm@openeuler.org References: <1611310732-51975-1-git-send-email-oulijun@huawei.com> <1611310732-51975-15-git-send-email-oulijun@huawei.com> <7d7acb57-d699-eba1-5e06-ac4c1c1deb1a@intel.com> <7638a4d0-fb62-131f-1e8c-f5945706b924@huawei.com> From: Ferruh Yigit Message-ID: <156f4d8c-c8f9-f9b3-6ddd-8373c43b2721@intel.com> Date: Tue, 2 Feb 2021 12:06:45 +0000 MIME-Version: 1.0 In-Reply-To: <7638a4d0-fb62-131f-1e8c-f5945706b924@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 14/14] net/hns3: support LSC event report X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/29/2021 1:49 AM, oulijun wrote: > > > 在 2021/1/29 7:41, Ferruh Yigit 写道: >> On 1/22/2021 10:18 AM, Lijun Ou wrote: >>> From: Chengwen Feng >>> >>> This patch support LSC(Link Status Change) event report. >> >> There is a user config for lsc, 'dev->data->dev_conf.intr_conf.lsc', which >> seems not taken into account. >> > Frist of all, thank you for your review. Currently, the old firmware doest not > support interrupt reporting. Therefore, the PF does not suport interrupt > reporting through the mailbox. Therefore, the PF obtains interrupts in polling > mode and then reports interrupts. > > >> Also 'RTE_PCI_DRV_INTR_LSC' should be set in 'rte_pci_driver.drv_flags' to >> report this feature to higher levels. >> > In the future, the new firmware + PF will support interrupt reporting. In that > case, the LSC capability of dev_flag will be set. > In the future, we will enable the VF to support LSC. That is, we are developing > the PF to report LSC interrupts through the mailbox. >> And when the feature is fully implemented, can you please add "Link status >> event" feature to 'hns3.ini'? >> > By then, we'll add it in hns3.ini. Got it, so for now only LSC event report (even callbacks call) support added, I am proceeding with the patch. >>> >>> Signed-off-by: Chengwen Feng >>> Signed-off-by: Lijun Ou >> >> <...> >> . >>