From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1D99DA2EDB for ; Wed, 2 Oct 2019 14:37:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 071421BEE7; Wed, 2 Oct 2019 14:37:02 +0200 (CEST) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 078C01BEE1 for ; Wed, 2 Oct 2019 14:36:59 +0200 (CEST) Received: from Internal Mail-Server by MTLPINE1 (envelope-from viacheslavo@mellanox.com) with ESMTPS (AES256-SHA encrypted); 2 Oct 2019 15:36:59 +0300 Received: from pegasus12.mtr.labs.mlnx (pegasus12.mtr.labs.mlnx [10.210.17.40]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x92Cawa3005249; Wed, 2 Oct 2019 15:36:58 +0300 Received: from pegasus12.mtr.labs.mlnx (localhost [127.0.0.1]) by pegasus12.mtr.labs.mlnx (8.14.7/8.14.7) with ESMTP id x92CawUn016388; Wed, 2 Oct 2019 12:36:58 GMT Received: (from viacheslavo@localhost) by pegasus12.mtr.labs.mlnx (8.14.7/8.14.7/Submit) id x92CavpN016386; Wed, 2 Oct 2019 12:36:57 GMT X-Authentication-Warning: pegasus12.mtr.labs.mlnx: viacheslavo set sender to viacheslavo@mellanox.com using -f From: Viacheslav Ovsiienko To: dev@dpdk.org Cc: rasland@mellanox.com, matan@mellanox.com, ferruh.yigit@intel.com, stephen@networkplumber.org Date: Wed, 2 Oct 2019 12:36:55 +0000 Message-Id: <1570019815-16177-1-git-send-email-viacheslavo@mellanox.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1569928223-6600-1-git-send-email-viacheslavo@mellanox.com> References: <1569928223-6600-1-git-send-email-viacheslavo@mellanox.com> Subject: [dpdk-dev] [PATCH v3] net/mlx5: fix compilation issue with gcc pragma X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The GCC compiler might generate warning or error if format parameter of fscanf is not literal. This was suppressed with GCC specific pragms. Some compilers (i.e Intel icc) do not recognize GCC diagnostic pragma, so the code was refactored with stringification, pragmas are not needed anymore. Fixes: a46a42b5cd03 ("net/mlx5: add VF LAG mode bonding device recognition") Signed-off-by: Viacheslav Ovsiienko --- v3: replace with RTE_STR stringifier v2: http://patches.dpdk.org/patch/60415/ code rewritten with stringification v1: http://patches.dpdk.org/patch/60310/ initial version with pragmas and compiler type check drivers/net/mlx5/mlx5.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 951b9f5..13d112e 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -2295,12 +2295,9 @@ struct mlx5_dev_spawn_data { } if (!file) return -1; - MKSTR(format, "%c%us", '%', (unsigned int)(sizeof(ifname) - 1)); - /* Use safe format to check maximal buffer length. */ -#pragma GCC diagnostic ignored "-Wformat-nonliteral" - while (fscanf(file, format, ifname) == 1) { -#pragma GCC diagnostic error "-Wformat-nonliteral" + assert(atol(RTE_STR(IF_NAMESIZE)) == IF_NAMESIZE); + while (fscanf(file, "%" RTE_STR(IF_NAMESIZE) "s", ifname) == 1) { char tmp_str[IF_NAMESIZE + 32]; struct rte_pci_addr pci_addr; struct mlx5_switch_info info; -- 1.8.3.1