From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id D75C0A3160
for <public@inbox.dpdk.org>; Wed, 9 Oct 2019 14:32:43 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 3BAB71D14B;
Wed, 9 Oct 2019 14:32:36 +0200 (CEST)
Received: from dispatchb-us1.ppe-hosted.com (dispatchb-us1.ppe-hosted.com
[148.163.129.53]) by dpdk.org (Postfix) with ESMTP id C92261C211;
Wed, 9 Oct 2019 14:32:31 +0200 (CEST)
X-Virus-Scanned: Proofpoint Essentials engine
Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))
(No client certificate requested)
by mx1-us2.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 4201D1C00BE;
Wed, 9 Oct 2019 12:32:30 +0000 (UTC)
Received: from ocex03.SolarFlarecom.com (10.20.40.36) by
ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id
15.0.1395.4; Wed, 9 Oct 2019 05:32:27 -0700
Received: from opal.uk.solarflarecom.com (10.17.10.1) by
ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id
15.0.1395.4 via Frontend Transport; Wed, 9 Oct 2019 05:32:26 -0700
Received: from ukv-loginhost.uk.solarflarecom.com
(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])
by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id x99CWOI6021030;
Wed, 9 Oct 2019 13:32:24 +0100
Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])
by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 4EB3A1613D4;
Wed, 9 Oct 2019 13:32:24 +0100 (BST)
From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>, Tiwei Bie
<tiwei.bie@intel.com>, Zhihong Wang <zhihong.wang@intel.com>
CC: <dev@dpdk.org>, <stable@dpdk.org>
Date: Wed, 9 Oct 2019 13:32:08 +0100
Message-ID: <1570624330-19119-4-git-send-email-arybchenko@solarflare.com>
X-Mailer: git-send-email 1.8.3.1
In-Reply-To: <1570624330-19119-1-git-send-email-arybchenko@solarflare.com>
References: <1569944672-24754-1-git-send-email-arybchenko@solarflare.com>
<1570624330-19119-1-git-send-email-arybchenko@solarflare.com>
MIME-Version: 1.0
Content-Type: text/plain
X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24964.005
X-TM-AS-Result: No-6.275800-4.000000-10
X-TMASE-MatchedRID: QtNN9W95DWvXba5cfJx+c4KvnFrZK2UhDnVIBRSEqxTfc2Xd6VJ+ypMa
95IHkZDCs4OIUtw/m6yqvQrjP8O+uiw76RUR9W5CqJSK+HSPY+/pVMb1xnESMgdkFovAReUogK6
qCGa1Z9cSndgYhkle2RIgSChh7f4dKh5xfxw1U6GKYdYQLbymTX0tCKdnhB585hDfNxdOhev6C0
ePs7A07Y6HM5rqDwqtZGN+uvd2O7kkI8weNx7EdGjD7RMB5T34s7F+TnIpmTYentNU6L88mEMMp
rcbiest
X-TM-AS-User-Approved-Sender: No
X-TM-AS-User-Blocked-Sender: No
X-TMASE-Result: 10--6.275800-4.000000
X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24964.005
X-MDID: 1570624350-zLbRLTh4LyC3
Subject: [dpdk-dev] [PATCH v2 4/4] net/virtio: reject unsupported Tx multi
queue modes
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
This driver supports none of DCB or VMDQ modes, therefore must
check and return error if configured incorrectly.
Fixes: c1f86306a026 ("virtio: add new driver")
Cc: stable@dpdk.org
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
drivers/net/virtio/virtio_ethdev.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
index 0af4fc392..7d3db4d73 100644
--- a/drivers/net/virtio/virtio_ethdev.c
+++ b/drivers/net/virtio/virtio_ethdev.c
@@ -2078,6 +2078,13 @@ virtio_dev_configure(struct rte_eth_dev *dev)
return -EINVAL;
}
+ if (txmode->mq_mode != ETH_MQ_TX_NONE) {
+ PMD_DRV_LOG(ERR,
+ "Unsupported Tx multi queue mode %d",
+ txmode->mq_mode);
+ return -EINVAL;
+ }
+
if (dev->data->dev_conf.intr_conf.rxq) {
ret = virtio_init_device(dev, hw->req_guest_features);
if (ret < 0)
--
2.17.1