* [dpdk-dev] [PATCH] devtools: add compressdev tests to test-build
@ 2018-07-11 7:17 Pablo de Lara
2018-07-11 15:49 ` Thomas Monjalon
2018-07-19 3:07 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
0 siblings, 2 replies; 6+ messages in thread
From: Pablo de Lara @ 2018-07-11 7:17 UTC (permalink / raw)
To: thomas; +Cc: dev, Pablo de Lara
Compressdev tests depend on Zlib library,
so they can only be enabled if this is available.
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
devtools/test-build.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/devtools/test-build.sh b/devtools/test-build.sh
index 3ea82bb46..059065891 100755
--- a/devtools/test-build.sh
+++ b/devtools/test-build.sh
@@ -154,6 +154,7 @@ config () # <directory> <target> <options>
test "$DPDK_DEP_ZLIB" != y || \
sed -ri 's,(BNX2X_PMD=)n,\1y,' $1/.config
sed -ri 's,(NFP_PMD=)n,\1y,' $1/.config
+ sed -ri 's,(COMPRESSDEV_TEST=)n,\1y,' $1/.config
test "$DPDK_DEP_PCAP" != y || \
sed -ri 's,(PCAP=)n,\1y,' $1/.config
test -z "$ARMV8_CRYPTO_LIB_PATH" || \
--
2.14.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] devtools: add compressdev tests to test-build
2018-07-11 7:17 [dpdk-dev] [PATCH] devtools: add compressdev tests to test-build Pablo de Lara
@ 2018-07-11 15:49 ` Thomas Monjalon
2018-07-16 17:33 ` De Lara Guarch, Pablo
2018-07-19 3:07 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
1 sibling, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2018-07-11 15:49 UTC (permalink / raw)
To: Pablo de Lara; +Cc: dev
11/07/2018 09:17, Pablo de Lara:
> Compressdev tests depend on Zlib library,
> so they can only be enabled if this is available.
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
> --- a/devtools/test-build.sh
> +++ b/devtools/test-build.sh
> @@ -154,6 +154,7 @@ config () # <directory> <target> <options>
> test "$DPDK_DEP_ZLIB" != y || \
> sed -ri 's,(BNX2X_PMD=)n,\1y,' $1/.config
> sed -ri 's,(NFP_PMD=)n,\1y,' $1/.config
> + sed -ri 's,(COMPRESSDEV_TEST=)n,\1y,' $1/.config
It is always enabled here.
You need to repeat the ZLIB condition for NFP and COMPRESSDEV_TEST.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] devtools: add compressdev tests to test-build
2018-07-11 15:49 ` Thomas Monjalon
@ 2018-07-16 17:33 ` De Lara Guarch, Pablo
2018-07-16 19:50 ` Thomas Monjalon
0 siblings, 1 reply; 6+ messages in thread
From: De Lara Guarch, Pablo @ 2018-07-16 17:33 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev
HI Thomas,
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Wednesday, July 11, 2018 4:50 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [PATCH] devtools: add compressdev tests to test-build
>
> 11/07/2018 09:17, Pablo de Lara:
> > Compressdev tests depend on Zlib library, so they can only be enabled
> > if this is available.
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > ---
> > --- a/devtools/test-build.sh
> > +++ b/devtools/test-build.sh
> > @@ -154,6 +154,7 @@ config () # <directory> <target> <options>
> > test "$DPDK_DEP_ZLIB" != y || \
> > sed -ri 's,(BNX2X_PMD=)n,\1y,' $1/.config
> > sed -ri 's,(NFP_PMD=)n,\1y,' $1/.config
> > + sed -ri 's,(COMPRESSDEV_TEST=)n,\1y,' $1/.config
>
> It is always enabled here.
> You need to repeat the ZLIB condition for NFP and COMPRESSDEV_TEST.
>
I see. So, does this mean that NFP PMD is always enabled? Do we need a fix for that?
Thanks,
Pablo
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] devtools: add compressdev tests to test-build
2018-07-16 17:33 ` De Lara Guarch, Pablo
@ 2018-07-16 19:50 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2018-07-16 19:50 UTC (permalink / raw)
To: De Lara Guarch, Pablo; +Cc: dev
16/07/2018 19:33, De Lara Guarch, Pablo:
> HI Thomas,
>
> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > Sent: Wednesday, July 11, 2018 4:50 PM
> > To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> > Cc: dev@dpdk.org
> > Subject: Re: [PATCH] devtools: add compressdev tests to test-build
> >
> > 11/07/2018 09:17, Pablo de Lara:
> > > Compressdev tests depend on Zlib library, so they can only be enabled
> > > if this is available.
> > >
> > > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > > ---
> > > --- a/devtools/test-build.sh
> > > +++ b/devtools/test-build.sh
> > > @@ -154,6 +154,7 @@ config () # <directory> <target> <options>
> > > test "$DPDK_DEP_ZLIB" != y || \
> > > sed -ri 's,(BNX2X_PMD=)n,\1y,' $1/.config
> > > sed -ri 's,(NFP_PMD=)n,\1y,' $1/.config
> > > + sed -ri 's,(COMPRESSDEV_TEST=)n,\1y,' $1/.config
> >
> > It is always enabled here.
> > You need to repeat the ZLIB condition for NFP and COMPRESSDEV_TEST.
> >
>
> I see. So, does this mean that NFP PMD is always enabled? Do we need a fix for that?
Exact
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH v2] devtools: add compressdev tests to test-build
2018-07-11 7:17 [dpdk-dev] [PATCH] devtools: add compressdev tests to test-build Pablo de Lara
2018-07-11 15:49 ` Thomas Monjalon
@ 2018-07-19 3:07 ` Pablo de Lara
2018-07-26 9:04 ` Thomas Monjalon
1 sibling, 1 reply; 6+ messages in thread
From: Pablo de Lara @ 2018-07-19 3:07 UTC (permalink / raw)
To: thomas; +Cc: dev, Pablo de Lara
Compressdev tests depend on Zlib library,
so they can only be enabled if this is available.
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
v2:
- Add test "$DPDK_DEP_ZLIB" != y" line, to actually check for the
Zlib dependency
devtools/test-build.sh | 2 ++
1 file changed, 2 insertions(+)
diff --git a/devtools/test-build.sh b/devtools/test-build.sh
index 3ea82bb46..0a420da0b 100755
--- a/devtools/test-build.sh
+++ b/devtools/test-build.sh
@@ -153,6 +153,8 @@ config () # <directory> <target> <options>
sed -ri 's,(PMD_SZEDATA2=)n,\1y,' $1/.config
test "$DPDK_DEP_ZLIB" != y || \
sed -ri 's,(BNX2X_PMD=)n,\1y,' $1/.config
+ test "$DPDK_DEP_ZLIB" != y || \
+ sed -ri 's,(COMPRESSDEV_TEST=)n,\1y,' $1/.config
sed -ri 's,(NFP_PMD=)n,\1y,' $1/.config
test "$DPDK_DEP_PCAP" != y || \
sed -ri 's,(PCAP=)n,\1y,' $1/.config
--
2.14.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2] devtools: add compressdev tests to test-build
2018-07-19 3:07 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
@ 2018-07-26 9:04 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2018-07-26 9:04 UTC (permalink / raw)
To: Pablo de Lara; +Cc: dev
19/07/2018 05:07, Pablo de Lara:
> Compressdev tests depend on Zlib library,
> so they can only be enabled if this is available.
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-07-26 9:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-11 7:17 [dpdk-dev] [PATCH] devtools: add compressdev tests to test-build Pablo de Lara
2018-07-11 15:49 ` Thomas Monjalon
2018-07-16 17:33 ` De Lara Guarch, Pablo
2018-07-16 19:50 ` Thomas Monjalon
2018-07-19 3:07 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
2018-07-26 9:04 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).