From: Simei Su <simei.su@intel.com>
To: qi.z.zhang@intel.com, xiaolong.ye@intel.com, qiming.yang@intel.com
Cc: dev@dpdk.org, simei.su@intel.com
Subject: [dpdk-dev] [PATCH] net/ice: change RSS rule destroy API
Date: Wed, 6 Nov 2019 09:36:01 +0800 [thread overview]
Message-ID: <1573004161-6693-1-git-send-email-simei.su@intel.com> (raw)
This patch changes RSS rule destroy API from ice_rem_vsi_rss_cfg()
to ice_rem_rss_cfg(). ice_rem_vsi_rss_cfg() removes RSS configurations
associated with VSI. ice_rem_rss_cfg() remove an existing RSS configuration
with matching hashed fields. To support input set change, we should adopt
ice_rem_rss_cfg(). This patch also fixes logic error otherwise
ice_rem_rss_cfg() is never be carried out.
Fixes: 5ad3db8d4bdd ("net/ice: enable advanced RSS")
Signed-off-by: Simei Su <simei.su@intel.com>
---
drivers/net/ice/ice_hash.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c
index 3381b45..ba83a12 100644
--- a/drivers/net/ice/ice_hash.c
+++ b/drivers/net/ice/ice_hash.c
@@ -464,6 +464,7 @@ struct ice_hash_match_type ice_hash_type_list[] = {
"No memory for filter_ptr");
return -ENOMEM;
}
+ filter_ptr->symm = 1;
if (hash_function == RTE_ETH_HASH_FUNCTION_SIMPLE_XOR) {
/* Enable registers for simple_xor hash function. */
@@ -528,7 +529,8 @@ struct ice_hash_match_type ice_hash_type_list[] = {
(1 << VSIQF_HASH_CTL_HASH_SCHEME_S);
ICE_WRITE_REG(hw, VSIQF_HASH_CTL(vsi->vsi_id), reg);
} else {
- ret = ice_rem_vsi_rss_cfg(hw, vsi->idx);
+ ret = ice_rem_rss_cfg(hw, vsi->idx,
+ filter_ptr->hashed_flds, filter_ptr->packet_hdr);
if (ret) {
rte_flow_error_set(error, EINVAL,
RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
--
1.8.3.1
next reply other threads:[~2019-11-06 1:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 1:36 Simei Su [this message]
2019-11-11 7:55 ` [dpdk-dev] [PATCH v2] net/ice: fix RSS rule destroy Simei Su
2019-11-12 0:09 ` Zhang, Qi Z
2019-11-12 1:14 ` Ye Xiaolong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1573004161-6693-1-git-send-email-simei.su@intel.com \
--to=simei.su@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).