From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 560F1A04AB; Tue, 12 Nov 2019 09:48:01 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E533D2BB1; Tue, 12 Nov 2019 09:47:54 +0100 (CET) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 1E016374 for ; Tue, 12 Nov 2019 09:47:50 +0100 (CET) Received: from Internal Mail-Server by MTLPINE1 (envelope-from matan@mellanox.com) with ESMTPS (AES256-SHA encrypted); 12 Nov 2019 10:47:47 +0200 Received: from pegasus07.mtr.labs.mlnx (pegasus07.mtr.labs.mlnx [10.210.16.112]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id xAC8ll0g025250; Tue, 12 Nov 2019 10:47:47 +0200 From: Matan Azrad To: dev@dpdk.org Cc: Gaetan Rivet , Bernard Iremonger , mukawa@igel.co.jp, stable@dpdk.org Date: Tue, 12 Nov 2019 08:47:38 +0000 Message-Id: <1573548459-6931-1-git-send-email-matan@mellanox.com> X-Mailer: git-send-email 1.8.3.1 Subject: [dpdk-dev] [PATCH 1/2] bus/pci: fix driver detach clear X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When a rte_device is unplugged, the driver should be detached from the device. The PCI detach driver operation wrongly didn't clear the driver from the device structure what remain the device in probe state from the EAL point of view. Clear the driver in driver detach successful operation. Fixes: dbe6b4b61b0e ("pci: probe or close device") Cc: mukawa@igel.co.jp Cc: stable@dpdk.org Signed-off-by: Matan Azrad --- drivers/bus/pci/pci_common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c index 6b46b4f..3f55420 100644 --- a/drivers/bus/pci/pci_common.c +++ b/drivers/bus/pci/pci_common.c @@ -247,6 +247,7 @@ static struct rte_devargs *pci_devargs_lookup(struct rte_pci_device *dev) /* clear driver structure */ dev->driver = NULL; + dev->device.driver = NULL; if (dr->drv_flags & RTE_PCI_DRV_NEED_MAPPING) /* unmap resources for devices that use igb_uio */ -- 1.8.3.1