From: Matan Azrad <matan@mellanox.com> To: dev@dpdk.org Cc: Gaetan Rivet <gaetan.rivet@6wind.com>, Bernard Iremonger <bernard.iremonger@intel.com>, thomas@monjalon.net, stable@dpdk.org Subject: [dpdk-dev] [PATCH 2/2] app/testpmd: fix invalid port detaching Date: Tue, 12 Nov 2019 08:47:39 +0000 Message-ID: <1573548459-6931-2-git-send-email-matan@mellanox.com> (raw) In-Reply-To: <1573548459-6931-1-git-send-email-matan@mellanox.com> The port was not validated before detaching. Ignore port detach operation when the port is not valid. Fixes: f8e5baa2662d ("app/testpmd: check not detaching device twice") Cc: thomas@monjalon.net Cc: stable@dpdk.org Signed-off-by: Matan Azrad <matan@mellanox.com> --- app/test-pmd/testpmd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 4444346..370eefe 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2545,6 +2545,9 @@ struct extmem_param { printf("Removing a device...\n"); + if (port_id_is_invalid(port_id, ENABLED_WARN)) + return; + dev = rte_eth_devices[port_id].device; if (dev == NULL) { printf("Device already removed\n"); -- 1.8.3.1
next prev parent reply other threads:[~2019-11-12 8:47 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-12 8:47 [dpdk-dev] [PATCH 1/2] bus/pci: fix driver detach clear Matan Azrad 2019-11-12 8:47 ` Matan Azrad [this message] 2019-11-12 11:20 ` [dpdk-dev] [PATCH 2/2] app/testpmd: fix invalid port detaching Iremonger, Bernard 2019-11-20 22:52 ` [dpdk-dev] [dpdk-stable] " David Marchand 2020-01-23 13:19 ` [dpdk-dev] " Yigit, Ferruh 2020-01-23 14:05 ` Matan Azrad 2020-01-23 14:48 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit 2020-01-23 15:29 ` Matan Azrad 2020-01-23 18:14 ` Ferruh Yigit 2020-01-23 19:25 ` Matan Azrad 2020-01-24 16:28 ` Ferruh Yigit 2020-01-25 18:56 ` Matan Azrad 2020-02-03 15:58 ` Ferruh Yigit 2020-02-03 17:10 ` Matan Azrad 2020-02-12 13:49 ` Ferruh Yigit 2020-02-13 12:37 ` Thomas Monjalon 2020-02-13 13:36 ` Thomas Monjalon 2020-02-13 14:00 ` Ferruh Yigit 2019-11-19 22:40 ` [dpdk-dev] [dpdk-stable] [PATCH 1/2] bus/pci: fix driver detach clear Thomas Monjalon 2019-11-20 9:02 ` Matan Azrad 2019-11-20 9:47 ` [dpdk-dev] [PATCH v2] " Matan Azrad 2019-11-20 13:03 ` [dpdk-dev] [dpdk-stable] " David Marchand 2019-11-20 13:44 ` Matan Azrad 2019-11-20 13:51 ` Thomas Monjalon 2019-11-20 17:22 ` David Marchand 2019-11-20 22:52 ` David Marchand
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1573548459-6931-2-git-send-email-matan@mellanox.com \ --to=matan@mellanox.com \ --cc=bernard.iremonger@intel.com \ --cc=dev@dpdk.org \ --cc=gaetan.rivet@6wind.com \ --cc=stable@dpdk.org \ --cc=thomas@monjalon.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git