DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] doc: announce deprecation of port mirroring API
@ 2020-08-03 15:33 Thomas Monjalon
  2020-08-03 15:35 ` Jerin Jacob
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Thomas Monjalon @ 2020-08-03 15:33 UTC (permalink / raw)
  To: dev
  Cc: david.marchand, jerinj, arybchenko, ferruh.yigit, stephen,
	ajit.khaparde, wei.zhao1, jiaweiw, orika, viacheslavo, matan

A new API is planned to be introduced for sampling and mirroring
with rte_flow. It should be more generic and allow more use cases.

This deprecation is to show the direction, avoiding overlapping APIs.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 doc/guides/rel_notes/deprecation.rst | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 6e12e57a13..ca0d8af96a 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -103,6 +103,12 @@ Deprecation Notices
   Existing ``rte_eth_rx_descriptor_status`` and ``rte_eth_tx_descriptor_status``
   APIs can be used as replacement.
 
+* ethdev: The port mirroring API can be replaced with a more fine grain flow API.
+  The structs ``rte_eth_mirror_conf``, ``rte_eth_vlan_mirror`` and the functions
+  ``rte_eth_mirror_rule_set``, ``rte_eth_mirror_rule_reset`` will be marked
+  as deprecated in DPDK 20.11, along with the associated macros ``ETH_MIRROR_*``.
+  This API will be fully removed in DPDK 21.11.
+
 * ethdev: Some internal APIs for driver usage are exported in the .map file.
   Now DPDK has ``__rte_internal`` marker so we can mark internal APIs and move
   them to the INTERNAL block in .map. Although these APIs are internal it will
-- 
2.27.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce deprecation of port mirroring API
  2020-08-03 15:33 [dpdk-dev] [PATCH] doc: announce deprecation of port mirroring API Thomas Monjalon
@ 2020-08-03 15:35 ` Jerin Jacob
  2020-08-03 15:36 ` Andrew Rybchenko
  2020-08-04  7:25 ` David Marchand
  2 siblings, 0 replies; 6+ messages in thread
From: Jerin Jacob @ 2020-08-03 15:35 UTC (permalink / raw)
  To: Thomas Monjalon
  Cc: dpdk-dev, David Marchand, Jerin Jacob, Andrew Rybchenko,
	Ferruh Yigit, Stephen Hemminger, Ajit Khaparde, wei.zhao1,
	Jiawei Wang, Ori Kam, Slava Ovsiienko, Matan Azrad

On Mon, Aug 3, 2020 at 9:03 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> A new API is planned to be introduced for sampling and mirroring
> with rte_flow. It should be more generic and allow more use cases.
>
> This deprecation is to show the direction, avoiding overlapping APIs.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Acked-by: Jerin Jacob <jerinj@marvell.com>


> ---
>  doc/guides/rel_notes/deprecation.rst | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 6e12e57a13..ca0d8af96a 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -103,6 +103,12 @@ Deprecation Notices
>    Existing ``rte_eth_rx_descriptor_status`` and ``rte_eth_tx_descriptor_status``
>    APIs can be used as replacement.
>
> +* ethdev: The port mirroring API can be replaced with a more fine grain flow API.
> +  The structs ``rte_eth_mirror_conf``, ``rte_eth_vlan_mirror`` and the functions
> +  ``rte_eth_mirror_rule_set``, ``rte_eth_mirror_rule_reset`` will be marked
> +  as deprecated in DPDK 20.11, along with the associated macros ``ETH_MIRROR_*``.
> +  This API will be fully removed in DPDK 21.11.
> +
>  * ethdev: Some internal APIs for driver usage are exported in the .map file.
>    Now DPDK has ``__rte_internal`` marker so we can mark internal APIs and move
>    them to the INTERNAL block in .map. Although these APIs are internal it will
> --
> 2.27.0
>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce deprecation of port mirroring API
  2020-08-03 15:33 [dpdk-dev] [PATCH] doc: announce deprecation of port mirroring API Thomas Monjalon
  2020-08-03 15:35 ` Jerin Jacob
@ 2020-08-03 15:36 ` Andrew Rybchenko
  2020-08-03 17:59   ` Ajit Khaparde
  2020-08-04  7:25 ` David Marchand
  2 siblings, 1 reply; 6+ messages in thread
From: Andrew Rybchenko @ 2020-08-03 15:36 UTC (permalink / raw)
  To: Thomas Monjalon, dev
  Cc: david.marchand, jerinj, ferruh.yigit, stephen, ajit.khaparde,
	wei.zhao1, jiaweiw, orika, viacheslavo, matan

On 8/3/20 6:33 PM, Thomas Monjalon wrote:
> A new API is planned to be introduced for sampling and mirroring
> with rte_flow. It should be more generic and allow more use cases.
>
> This deprecation is to show the direction, avoiding overlapping APIs.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

I like the idea. Not everything is 100% clear, but the direction is right.

Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce deprecation of port mirroring API
  2020-08-03 15:36 ` Andrew Rybchenko
@ 2020-08-03 17:59   ` Ajit Khaparde
  2020-08-06  0:44     ` Thomas Monjalon
  0 siblings, 1 reply; 6+ messages in thread
From: Ajit Khaparde @ 2020-08-03 17:59 UTC (permalink / raw)
  To: Andrew Rybchenko
  Cc: Thomas Monjalon, dpdk-dev, David Marchand,
	Jerin Jacob Kollanukkaran, Ferruh Yigit, Stephen Hemminger,
	Zhao1, Wei, Jiawei(Jonny) Wang, Ori Kam, Viacheslav Ovsiienko,
	Matan Azrad

On Mon, Aug 3, 2020 at 8:36 AM Andrew Rybchenko <arybchenko@solarflare.com>
wrote:

> On 8/3/20 6:33 PM, Thomas Monjalon wrote:
> > A new API is planned to be introduced for sampling and mirroring
> > with rte_flow. It should be more generic and allow more use cases.
> >
> > This deprecation is to show the direction, avoiding overlapping APIs.
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>
> I like the idea. Not everything is 100% clear, but the direction is right.
>
+1


>
> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
>
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce deprecation of port mirroring API
  2020-08-03 15:33 [dpdk-dev] [PATCH] doc: announce deprecation of port mirroring API Thomas Monjalon
  2020-08-03 15:35 ` Jerin Jacob
  2020-08-03 15:36 ` Andrew Rybchenko
@ 2020-08-04  7:25 ` David Marchand
  2 siblings, 0 replies; 6+ messages in thread
From: David Marchand @ 2020-08-04  7:25 UTC (permalink / raw)
  To: Thomas Monjalon
  Cc: dev, Jerin Jacob Kollanukkaran, Andrew Rybchenko, Yigit, Ferruh,
	Stephen Hemminger, Ajit Khaparde, Wei Zhao, jiaweiw, Ori Kam,
	Viacheslav Ovsiienko, Matan Azrad

On Mon, Aug 3, 2020 at 5:33 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> A new API is planned to be introduced for sampling and mirroring
> with rte_flow. It should be more generic and allow more use cases.
>
> This deprecation is to show the direction, avoiding overlapping APIs.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Acked-by: David Marchand <david.marchand@redhat.com>


-- 
David Marchand


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce deprecation of port mirroring API
  2020-08-03 17:59   ` Ajit Khaparde
@ 2020-08-06  0:44     ` Thomas Monjalon
  0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2020-08-06  0:44 UTC (permalink / raw)
  To: dev
  Cc: Andrew Rybchenko, David Marchand, Jerin Jacob Kollanukkaran,
	Ferruh Yigit, Stephen Hemminger, Zhao1, Wei, Jiawei(Jonny) Wang,
	Ori Kam, Viacheslav Ovsiienko, Matan Azrad, Ajit Khaparde

> > > A new API is planned to be introduced for sampling and mirroring
> > > with rte_flow. It should be more generic and allow more use cases.
> > >
> > > This deprecation is to show the direction, avoiding overlapping APIs.
> > >
> > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Acked-by: Jerin Jacob <jerinj@marvell.com>
> > 
> > I like the idea. Not everything is 100% clear, but the direction is right.
> >
> +1
> 
> > Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Acked-by: David Marchand <david.marchand@redhat.com>

Applied



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-08-06  0:45 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-03 15:33 [dpdk-dev] [PATCH] doc: announce deprecation of port mirroring API Thomas Monjalon
2020-08-03 15:35 ` Jerin Jacob
2020-08-03 15:36 ` Andrew Rybchenko
2020-08-03 17:59   ` Ajit Khaparde
2020-08-06  0:44     ` Thomas Monjalon
2020-08-04  7:25 ` David Marchand

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git