From: Thomas Monjalon <thomas@monjalon.net>
To: Chas Williams <chas3@att.com>
Cc: dev@dpdk.org, "Ananyev,
Konstantin" <konstantin.ananyev@intel.com>,
Chas Williams <3chas3@gmail.com>
Subject: Re: [dpdk-dev] [PATCH] ip_frag: fix ipv6 when MTU sizes not aligned to 8 bytes
Date: Wed, 19 Dec 2018 22:37:33 +0100 [thread overview]
Message-ID: <1574497.3ne19FqZsX@xps> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB977258010D8BC664@IRSMSX106.ger.corp.intel.com>
> > The same issue was fixed on for the ipv4 version of this routine in
> > commit 8d4d3a4f7337 ("ip_frag: handle MTU sizes not aligned to 8 bytes").
> > Briefly, the size of an ipv6 header is always 40 bytes. With an MTU of
> > 1500, this will never produce a multiple of 8 bytes for the frag_size
> > and this routine can never succeed. Since RTE_ASSERTS are disabled by
> > default, this failure is tpyically ignored.
> >
> > To fix this, round down to the nearest 8 bytes and use this when
> > producing the fragments.
> >
> > Fixes: 0aa31d7a5929 ("ip_frag: add IPv6 fragmentation support")
> >
> > Signed-off-by: Chas Williams <chas3@att.com>
>
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Applied, thanks
prev parent reply other threads:[~2018-12-19 21:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 4:56 Chas Williams
2018-11-28 10:15 ` Luca Boccassi
2018-12-19 3:47 ` Thomas Monjalon
2018-12-19 10:12 ` Ananyev, Konstantin
2018-12-19 21:37 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1574497.3ne19FqZsX@xps \
--to=thomas@monjalon.net \
--cc=3chas3@gmail.com \
--cc=chas3@att.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).