From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8E21BA04E0; Wed, 27 Nov 2019 06:01:23 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2EB9D2B88; Wed, 27 Nov 2019 06:01:22 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 06EE2A3 for ; Wed, 27 Nov 2019 06:01:20 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xAR4vK1f009040; Tue, 26 Nov 2019 21:01:20 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=pfpt0818; bh=djlTJ4aGAjEfEXm6bx9xKCTSH+Ji/rQzcKahgUj9YfU=; b=MGYLZJBPJGsm3cPgPwfoJMovGimb5tbWZUuOW8qJ04XwFqFP59nvb8ALGzqZ58u2JNrh F/c7ge/7BZ/7IIW2BBgZAqSvYDb2VbHO44bIxc+m3+N6FeabvaNZTlB4GtCPcKPb8i4V JuuIRLRk7mmrirdAxhKRQXvTZRmcwNDN/6npiT0BobzGoZuYiThetCKbNph5SXR5vENM N4gPxh+ZBmfy02nBxJGoHgCKG/QvaYIL/i8sqKpGnAD3q2W8J8TRrMBjeKiqcIN/5AVo C6xeZVqK+/7zum96QFi6q4CMF0y3dhNaC8KaXJwg/+p2p/Ra6Bmy0RNwuZ6DIL7OKruw YA== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0b-0016f401.pphosted.com with ESMTP id 2whd08h7wr-3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 26 Nov 2019 21:01:20 -0800 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 26 Nov 2019 21:01:18 -0800 Received: from maili.marvell.com (10.93.176.43) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server id 15.0.1367.3 via Frontend Transport; Tue, 26 Nov 2019 21:01:18 -0800 Received: from ajoseph83.caveonetworks.com.com (unknown [10.29.45.60]) by maili.marvell.com (Postfix) with ESMTP id F285D3F703F; Tue, 26 Nov 2019 21:01:15 -0800 (PST) From: Anoob Joseph To: Marko Kovacevic , Akhil Goyal , Pablo de Lara CC: Sucharitha Sarananaga , Jerin Jacob , Narayana Prasad , , Anoob Joseph Date: Wed, 27 Nov 2019 10:30:48 +0530 Message-ID: <1574830848-19137-1-git-send-email-anoobj@marvell.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572 definitions=2019-11-26_08:2019-11-26,2019-11-26 signatures=0 Subject: [dpdk-dev] [PATCH] examples/fips_validation: fix incorrect structure used for AES-GCM X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Sucharitha Sarananaga Test vectors for AES-GCM need to be populated by using aead member and not cipher_auth. Using incorrect member would result in failures when AES-GCM with non-zero AAD is tried. Bugzilla ID: 360 Fixes: 4aaad2995e13 ("examples/fips_validation: support GCM parsing") Signed-off-by: Anoob Joseph Signed-off-by: Sucharitha Sarananaga --- examples/fips_validation/fips_validation_gcm.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/examples/fips_validation/fips_validation_gcm.c b/examples/fips_validation/fips_validation_gcm.c index 0509b10..ea48ddf 100644 --- a/examples/fips_validation/fips_validation_gcm.c +++ b/examples/fips_validation/fips_validation_gcm.c @@ -34,29 +34,29 @@ #define NEG_TEST_STR "FAIL" struct fips_test_callback gcm_dec_vectors[] = { - {KEY_STR, parse_uint8_known_len_hex_str, &vec.cipher_auth.key}, + {KEY_STR, parse_uint8_known_len_hex_str, &vec.aead.key}, {IV_STR, parse_uint8_known_len_hex_str, &vec.iv}, {CT_STR, parse_uint8_known_len_hex_str, &vec.ct}, - {AAD_STR, parse_uint8_known_len_hex_str, &vec.cipher_auth.aad}, + {AAD_STR, parse_uint8_known_len_hex_str, &vec.aead.aad}, {TAG_STR, parse_uint8_known_len_hex_str, - &vec.cipher_auth.digest}, + &vec.aead.digest}, {NULL, NULL, NULL} /**< end pointer */ }; struct fips_test_callback gcm_interim_vectors[] = { - {KEYLEN_STR, parser_read_uint32_bit_val, &vec.cipher_auth.key}, + {KEYLEN_STR, parser_read_uint32_bit_val, &vec.aead.key}, {IVLEN_STR, parser_read_uint32_bit_val, &vec.iv}, {PTLEN_STR, parser_read_uint32_bit_val, &vec.pt}, - {AADLEN_STR, parser_read_uint32_bit_val, &vec.cipher_auth.aad}, + {AADLEN_STR, parser_read_uint32_bit_val, &vec.aead.aad}, {TAGLEN_STR, parser_read_uint32_bit_val, - &vec.cipher_auth.digest}, + &vec.aead.digest}, {NULL, NULL, NULL} /**< end pointer */ }; struct fips_test_callback gcm_enc_vectors[] = { - {KEY_STR, parse_uint8_known_len_hex_str, &vec.cipher_auth.key}, + {KEY_STR, parse_uint8_known_len_hex_str, &vec.aead.key}, {IV_STR, parse_uint8_known_len_hex_str, &vec.iv}, {PT_STR, parse_uint8_known_len_hex_str, &vec.pt}, - {AAD_STR, parse_uint8_known_len_hex_str, &vec.cipher_auth.aad}, + {AAD_STR, parse_uint8_known_len_hex_str, &vec.aead.aad}, {NULL, NULL, NULL} /**< end pointer */ }; -- 2.7.4