From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) by dpdk.org (Postfix) with ESMTP id 8A0E1B108 for ; Fri, 16 May 2014 16:41:51 +0200 (CEST) Received: by mail-wi0-f176.google.com with SMTP id n15so1071231wiw.15 for ; Fri, 16 May 2014 07:41:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=e9AAfIZeEs+Wy2aMGd2JCzA6/BCY0b6k5NQcY/3GaCE=; b=QD2rzXGy09BFdAkGrCUjCauchk81CWhGH3amjQtoq6FK1EIRlhZvfXCqBvQo4w6zfB dWC21KQGd4ZcrdbnmSKu/xOxaDqNDkUIqYoL/QtISfd2RpHB6JgHZ34bviGXFlPROAmm ZNafGmpKYPrxbK7hzAuW6zqajrv1ZeAyPNHbFQj+xblOcV7lwPp4sG8iO5r9Z9E8KDm6 v8XdG1RrHNx1oXaKXDDU1rU6fa7Ir/UsTu1SbDIOLnjqIW8F6ElHAPbF6ORfSIWSW/Ng eDCWBUHV0pGTxOw8BKVbFoU1zOnbtjo5g4F76uSUDLK+2GKEcMxT26ARJ7r3M6dYudhA UzrA== X-Gm-Message-State: ALoCoQnZygUOG4ZoYO+vxoIHqMQrb/Fy/pFm5ddobCgpaJDtD6cfC7SSb2KkhtI5Pbmsvr/zMqlQ X-Received: by 10.180.19.167 with SMTP id g7mr14210323wie.46.1400251319726; Fri, 16 May 2014 07:41:59 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id km6sm2165300wjc.6.2014.05.16.07.41.57 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 May 2014 07:41:58 -0700 (PDT) From: Thomas Monjalon To: "Burakov, Anatoly" Date: Fri, 16 May 2014 16:41:55 +0200 Message-ID: <1575992.oUxJQ8gJcF@xps13> Organization: 6WIND User-Agent: KMail/4.13 (Linux/3.14.4-1-ARCH; KDE/4.13.0; x86_64; ; ) In-Reply-To: References: <20140502234251.707598579@vyatta.com> <20140502234407.841791092@vyatta.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 5/5] add FILE arguement to debug functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 May 2014 14:41:51 -0000 2014-05-06 12:52, Burakov, Anatoly: > Hi Stephen, > > > The DPDK dump functions are useful for remote debugging of an > > applications. But when application runs as a daemon, stdout > > is typically routed to /dev/null. > > > > Instead change all these functions to take a stdio FILE * handle > > instead. An application can then use open_memstream() to capture > > the output. > > Wouldn't it be better to leave old calls as wrappers with the FILE parameter > defaulting to stdout? That way you wouldn't have to change so much code, > keep backwards compatibility with old code, and get the additional > functionality you need. Refactoring code shouldn't be a problem. We didn't commit for API stability yet. Acked-by: Thomas Monjalon