From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f175.google.com (mail-we0-f175.google.com [74.125.82.175]) by dpdk.org (Postfix) with ESMTP id 08DB75A82 for ; Mon, 19 Jan 2015 18:23:04 +0100 (CET) Received: by mail-we0-f175.google.com with SMTP id k11so32683360wes.6 for ; Mon, 19 Jan 2015 09:23:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=cz1x/1T39JZnrqj5h/PTJcc0Q31LnTO3cm8JUVbOyy0=; b=JSffhOQJHVTVzIuDag0d1jUS5x6LHssYzRla2qtnrq+5+RLyN7P5lUlKnRO3OLWBZ6 Zxs6Hr+BDud49y2e8I0xRDPtiUkzf40vAXLTsL4hkC7zL/TFuB+iYlFkahqFw/kbvFD7 y/8gIbGuZ3W9pL9bZo28PEloR6B2ijnhnuzmj5Uyu90v+Axqq8yM6A6f9t80yLQ4n5b6 +hEusdRsbtwui3yjnBRCyjK18QxFevdz66LkMXis4YnuxAa4sCp22juwFZ/ZIfSBkn8V 83zUAwl8qP3ATCSMkOfBGLmQ6W4fVOIDcQa/Smwu+Y4iTkPkeEcltlVW51i8uFPXcXY4 vutQ== X-Gm-Message-State: ALoCoQk9GzjzkJKBBx8099ntp39/qlt/SrMyuEu+MqI5EZAMw69lgUbhr+4QrnrVY1VOIlBRGBew X-Received: by 10.180.88.33 with SMTP id bd1mr37038319wib.10.1421688183800; Mon, 19 Jan 2015 09:23:03 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id j1sm18041479wjw.25.2015.01.19.09.23.02 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Jan 2015 09:23:02 -0800 (PST) From: Thomas Monjalon To: Konstantin Ananyev Date: Mon, 19 Jan 2015 18:22:40 +0100 Message-ID: <1576198.aXfb5MeZ7p@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.6-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <1421090181-17150-12-git-send-email-konstantin.ananyev@intel.com> References: <1421090181-17150-1-git-send-email-konstantin.ananyev@intel.com> <1421090181-17150-12-git-send-email-konstantin.ananyev@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 11/17] librte_acl: add AVX2 as new rte_acl_classify() method X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jan 2015 17:23:04 -0000 2015-01-12 19:16, Konstantin Ananyev: > +/* > + * Select highest avaialbe classify method as default one. Typo here. Actually, I've seen few typos when browsing your big patchset but I don't remember exactly where. Maybe that a tool like codespell could help. [...] > + else if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_SSE4_1)) > +#else > if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_SSE4_1)) > +#endif Minor nit, it could be + else +#endif if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_SSE4_1)) -- Thomas