From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) by dpdk.org (Postfix) with ESMTP id EA1C25A62 for ; Fri, 27 Mar 2015 11:06:05 +0100 (CET) Received: by wibbg6 with SMTP id bg6so20450536wib.0 for ; Fri, 27 Mar 2015 03:06:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=FjbLSsNxn8d0TWYV5TlNDfS06mQ4N9AmH3Szyp2rNL8=; b=h8OVSiOpK7J9yMcT/lMTwh89hjbzzPiSZA1ZlMksOG9U1Fn59seLktYS0Lqgo1I5O6 BmJ6XwnbPAx974D41fq9s0J5eIAnNNU1Tey9r3iAMD7ujFPV9pC8ccUSOuabm4Ktygi3 id3MhM1fTon2PQjhE2GT+RqOSX0cc57I2HspT5pdvVYQ9vSjaGJDYZ76JIGAqCMwp3s4 wXxaUOai8ah9PK5uqGwzz+e6DQzVVpp2Sf3D/4VzHOlOrasUCM4kmOvzWspJN7G4oqq4 tvVRY0m7PzekaXLSnxk9R8BVm1eI5sm48FXE8xQm/ugrUvy3O8/AGRIogroyuAi5v7Dv 6wOA== X-Gm-Message-State: ALoCoQk+WgUy/kQTZUAVHsPgBBO//0q/yV/uZ/Bmg+x493sjRkPgD7XX5TPoBkFVnpxC/Z2SAHVG X-Received: by 10.181.11.202 with SMTP id ek10mr53326446wid.37.1427450765856; Fri, 27 Mar 2015 03:06:05 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id a13sm2098958wjx.30.2015.03.27.03.06.04 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Mar 2015 03:06:04 -0700 (PDT) From: Thomas Monjalon To: "Richardson, Bruce" Date: Fri, 27 Mar 2015 11:05:24 +0100 Message-ID: <1578031.OQmMz318h0@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: References: <1427389365-18631-1-git-send-email-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] ethdev: fix crash with multiprocess X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Mar 2015 10:06:06 -0000 2015-03-26 17:36, De Lara Guarch, Pablo: > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson > > The data structure for the rx and tx callbacks is local to each process > > since it contains function pointers and cannot be shared between > > different unique binaries. However, because it is not in > > rte_eth_dev_data structure, the array is not getting initialized for > > secondary processes - neither is it getting appropriately resized if the > > number of RX/TX queues changes. This causes crashes in secondary > > processes as they dereference a null pointer in struct rte_eth_dev. > > > > This patch fixes this by introducing an upper-bound on the number of > > queues per port that can be configured, and then uses this to make the > > array statically sized, thereby avoiding the crashes. > > > > Signed-off-by: Bruce Richardson > > Tested-by: Pablo de Lara Fixes: 4dc294158cac ("ethdev: support optional Rx and Tx callbacks") Acked-by: Thomas Monjalon Applied, thanks The multiprocess design is difficult to maintain. It would be better to have someone registered as maintainer of this part.