From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 58BD010D14 for ; Thu, 22 Dec 2016 12:07:45 +0100 (CET) Received: by mail-wm0-f51.google.com with SMTP id a197so172372816wmd.0 for ; Thu, 22 Dec 2016 03:07:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=alFMyDeORNaGJ8sgQZvYnM87EO1z9VT3d6pK3qEwWLA=; b=zlF8svs+DT5pxdhbWwKbz1Rje+GGpqPJeU9HduHsykN66HP5FTT1EVbmOONxB4bD0b LPrh2LHlFuRm1pHWNgQD3I0tK11wD9p3lTjij53ln+fL9kKEUuw09OujDUA46/dqKrcZ rQ8NDxwB3xFx2zTKTExRgHI7DFxltyLNevgUGU3fV3k7EekvKuUUONGBjEyZQj0oOVte fUArJXv6KAZoCmat5NW5eLxlsaCM3LqS7iwA+9dWEodaF8q7S86I7QbeTc1EPI3LvGHN uVzRleEim/u+XaGztQhoYJ0cEq7YdF7ssbBs1CTtAbz9arqGXCPEruwBGOJ534z2E0cK IhiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=alFMyDeORNaGJ8sgQZvYnM87EO1z9VT3d6pK3qEwWLA=; b=Hqgho/HmdGhMBaDVx+WMHs2o7nyCCqeO2V7C4Hotcou4qhpbIjUVMClom3nT91hyNF j/HfSTRDoBuFhY12ugbsn+NwKH21d89uEkHdgSQilOlOD5Eh1yYMHSHUMtt8A3fbxlgj DfP4EnR+4A1IP035kNXvui/ZCtrQzbQvqj8sKGFkWi5evhu3f0OO8SIRiQ6jQjafIrjs 3iuTf8NsY7GZm5ykui9LvHQoGnVIjsIvRPXPhR1qFKaOyaoumkHNREU2QHUVCiyIwrOE 171AF6lPn10JfTJrTWY7Bay+pvtDIcVQHETtS0T+lJyqeAwCBdjaOxZLfP2JPiQ7MteJ UpLA== X-Gm-Message-State: AIkVDXLdBKjd99j4WX7f852KX2dUTwZTILYE8pvJbB6IEis1ES98CJnkLfD0SQBX0HJADYcu X-Received: by 10.28.236.83 with SMTP id k80mr8792039wmh.0.1482404865080; Thu, 22 Dec 2016 03:07:45 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id w18sm31707124wme.9.2016.12.22.03.07.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Dec 2016 03:07:44 -0800 (PST) From: Thomas Monjalon To: Qiming Yang Cc: dev@dpdk.org, Remy Horton Date: Thu, 22 Dec 2016 12:07:43 +0100 Message-ID: <1578263.GeZ0IiYehl@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1479375779-46629-2-git-send-email-qiming.yang@intel.com> <1481008582-69416-1-git-send-email-qiming.yang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 0/5] example/ethtool: add bus info and fw version get X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Dec 2016 11:07:45 -0000 2016-12-08 16:34, Remy Horton: > > On 06/12/2016 15:16, Qiming Yang wrote: > [..] > > Qiming Yang (5): > > ethdev: add firmware version get > > net/e1000: add firmware version get > > net/ixgbe: add firmware version get > > net/i40e: add firmware version get > > ethtool: dispaly bus info and firmware version > > s/dispaly/display > > doc/guides/rel_notes/release_17_02.rst ought to be updated as well. Code > itself looks ok though.. > > Acked-by: Remy Horton It must be a feature in the table (doc/guides/nics/features/). The deprecation notice must be removed also. I think it is OK to add a new dev_ops and a new API function for firmware query. Generally speaking, it is a good thing to avoid putting all informations in the same structure (e.g. rte_eth_dev_info). However, there is a balance to find. Could we plan to add more info to this new query? Instead of rte_eth_dev_fwver_get(uint8_t port_id, char *fw_version, int fw_length) could it fill a struct? rte_eth_dev_fw_info_get(uint8_t port_id, struct rte_eth_dev_fw_info *fw_info) We already have rte_eth_dev_get_reg_info(uint8_t port_id, struct rte_dev_reg_info *info) with uint32_t version; /**< Device version */ There are also these functions (a bit related): rte_eth_dev_get_eeprom_length(uint8_t port_id) rte_eth_dev_get_eeprom(uint8_t port_id, struct rte_dev_eeprom_info *info)