From: Bernard Iremonger <bernard.iremonger@intel.com>
To: dev@dpdk.org, beilei.xing@intel.com, qi.z.zhang@intel.com,
ferruh.yigit@intel.com, rory.sexton@intel.com
Cc: Bernard Iremonger <bernard.iremonger@intel.com>
Subject: [dpdk-dev] [PATCH] net/i40e: fix i40e flow director merge
Date: Tue, 21 Jan 2020 16:02:13 +0000 [thread overview]
Message-ID: <1579622533-15909-1-git-send-email-bernard.iremonger@intel.com> (raw)
Merge of i40e_fdir.c added checks on cus_pctype->index which are not
necessary and caused flow creation for ESP to fail.
Removed the added lines to fix the issue.
Fixes: c5f8365bc85d ("net/i40e: support flow director for L2TPv3 over IP")
Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
---
drivers/net/i40e/i40e_fdir.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c
index c346073..1d7c392 100644
--- a/drivers/net/i40e/i40e_fdir.c
+++ b/drivers/net/i40e/i40e_fdir.c
@@ -1063,12 +1063,7 @@ i40e_flow_fdir_fill_eth_ip_head(struct i40e_pf *pf,
pctype == I40E_FILTER_PCTYPE_NONF_IPV4_SCTP ||
pctype == I40E_FILTER_PCTYPE_NONF_IPV4_OTHER ||
pctype == I40E_FILTER_PCTYPE_FRAG_IPV4 ||
- ((is_customized_pctype) &&
- ((cus_pctype->index == I40E_CUSTOMIZED_GTPC) ||
- (cus_pctype->index == I40E_CUSTOMIZED_GTPU_IPV4) ||
- (cus_pctype->index == I40E_CUSTOMIZED_GTPU_IPV6) ||
- (cus_pctype->index == I40E_CUSTOMIZED_GTPU) ||
- (cus_pctype->index == I40E_CUSTOMIZED_IPV4_L2TPV3)))) {
+ is_customized_pctype) {
ip = (struct rte_ipv4_hdr *)raw_pkt;
*ether_type = rte_cpu_to_be_16(RTE_ETHER_TYPE_IPV4);
--
2.7.4
next reply other threads:[~2020-01-21 16:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 16:02 Bernard Iremonger [this message]
2020-01-21 16:28 ` Iremonger, Bernard
2020-01-21 16:42 ` Sexton, Rory
2020-01-22 15:20 ` [dpdk-dev] [PATCH v2] " Bernard Iremonger
2020-01-22 15:48 ` Sexton, Rory
2020-01-28 13:48 ` [dpdk-dev] [PATCH v3] " Bernard Iremonger
2020-01-29 10:10 ` Sexton, Rory
2020-02-10 9:19 ` Ye Xiaolong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1579622533-15909-1-git-send-email-bernard.iremonger@intel.com \
--to=bernard.iremonger@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=rory.sexton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).