From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 673CFA0350; Thu, 25 Jun 2020 12:14:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E4E4FDE0; Thu, 25 Jun 2020 12:14:57 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id D666DA3 for ; Thu, 25 Jun 2020 12:14:56 +0200 (CEST) IronPort-SDR: qpnvrIucovaCwJJMJCeJ6KJ6MsXIP0rluixxJQ3z/gm5zlQIkqg9Q8EXurBxIjSMqojdc4X8D4 hPEgJy6xwQfw== X-IronPort-AV: E=McAfee;i="6000,8403,9662"; a="206362590" X-IronPort-AV: E=Sophos;i="5.75,278,1589266800"; d="scan'208";a="206362590" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2020 03:14:55 -0700 IronPort-SDR: 0nVUZNrG5FUR4UcN9LyKlPtW9Tmms98fZYKKHGJJF6KAvyOyACFYR0eE3Z4OJUNrFzlvLACCIQ /yFAjwI0zN7g== X-IronPort-AV: E=Sophos;i="5.75,278,1589266800"; d="scan'208";a="452957228" Received: from dhunt5-mobl5.ger.corp.intel.com (HELO [10.213.237.42]) ([10.213.237.42]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2020 03:14:55 -0700 To: "Sexton, Rory" , dev@dpdk.org References: <20200518103902.27927-1-rory.sexton@intel.com> From: "Hunt, David" Message-ID: <157b8cd9-d93a-6fcf-30f1-1c6631201a9a@intel.com> Date: Thu, 25 Jun 2020 11:14:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200518103902.27927-1-rory.sexton@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v2 1/3] examples/vm_power_manager: Make branch ratio threshold per core X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Rory, On 18/5/2020 11:39 AM, Sexton, Rory wrote: > This modification allows for the branch ratio threshold to be set > per core rather than system wide. This gives greater flexibility to > the branch ration monitoring allowing it to manage different > workloads with different characteristics on the same system. > > Signed-off-by: Rory Sexton > --- > examples/vm_power_manager/main.c | 40 +++++++++++--------- > examples/vm_power_manager/oob_monitor_x86.c | 2 +- > examples/vm_power_manager/parse.c | 42 ++++++++++++++++++++- > examples/vm_power_manager/parse.h | 3 ++ > examples/vm_power_manager/power_manager.c | 2 +- > examples/vm_power_manager/power_manager.h | 2 +- > 6 files changed, 68 insertions(+), 23 deletions(-) This change is a good enhancement, as there are usually different types of workload running on the cores in a system, each requiring a different ratio. Also, it's good that multiple groups of cores can be specified by using the parameter multiple times, e.g. -b 21-23:0.5 -b 24,25:0.4 LGTM. Reviewed-by: David Hunt