From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D630A0524; Thu, 30 Jan 2020 22:04:43 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E109A1C02D; Thu, 30 Jan 2020 22:04:42 +0100 (CET) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id AC3DF1C02C for ; Thu, 30 Jan 2020 22:04:41 +0100 (CET) Received: from Internal Mail-Server by MTLPINE1 (envelope-from orika@mellanox.com) with ESMTPS (AES256-SHA encrypted); 30 Jan 2020 23:04:36 +0200 Received: from pegasus03.mtr.labs.mlnx (pegasus03.mtr.labs.mlnx [10.210.16.124]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 00UL4HCa014005; Thu, 30 Jan 2020 23:04:36 +0200 From: Ori Kam To: Wenzhuo Lu , Jingjing Wu , Bernard Iremonger Cc: dev@dpdk.org, orika@mellanox.com, ferruh.yigit@intel.com, viacheslavo@mellanox.com Date: Thu, 30 Jan 2020 21:04:04 +0000 Message-Id: <1580418244-6462-1-git-send-email-orika@mellanox.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1580390564-186435-1-git-send-email-orika@mellanox.com> References: <1580390564-186435-1-git-send-email-orika@mellanox.com> Subject: [dpdk-dev] [PATCH v3] app/testpmd: fix copying the name of the dynflag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When working with testpmd and setting the dynflag name, we copy the name given by the cmd to the dynflag name. The issue is that the size of the dynflag name is smaller then the string used by testpmd. This commit solves this issue by checking that the length of the requested flag name is not too long. Coverity issue: 353610 Fixes: b57b66a97ebf ("app/testpmd: support mbuf dynamic flag") Signed-off-by: Ori Kam --- V3: * Fix style issue. V2: * change to check the requested flag name. --- app/test-pmd/cmdline.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index dab22bc..7ccc778 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -18865,6 +18865,10 @@ struct cmd_config_tx_dynf_specific_result { if (port_id_is_invalid(res->port_id, ENABLED_WARN)) return; + if (strlen(res->name) > sizeof(desc_flag.name)) { + printf("Flag name too long\n"); + return; + } flag = rte_mbuf_dynflag_lookup(res->name, NULL); if (flag <= 0) { strcpy(desc_flag.name, res->name); -- 1.8.3.1