From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id BB7581B44D for ; Thu, 2 Aug 2018 10:27:00 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 2DF2B21BD9; Thu, 2 Aug 2018 04:27:00 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 02 Aug 2018 04:27:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=G9uqRuSoCezo0jiKAVvHU1Gr6A IkSdrFSPIrbQSwBro=; b=BsTynxbjLJbTVXHbSqoedPo1YEbKca8qESXXPr6HLX RaQMQk6qV4eePwlG+sbd6zKHvIKtQB1nqWeSI2xGwdqYvMyFfysmrOejIdz4SrPP 8tAuLZnMAfFrTzCC+MTMY6NeoN84jVVQGOk/z0MvvqBDBsvo95cpZ7EkgPL0SHsa o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=G9uqRu SoCezo0jiKAVvHU1Gr6AIkSdrFSPIrbQSwBro=; b=lJhkpZTQ6P0Gdc4dZxgbxW eftXK6wNZexeJ2tpUoSqijaCFIygNCh8Kt5S12KKgLQIrfETrl1oE4kg+42B9ka+ gk0uZVXX/kCvhzADK+ajc6P6jp4SA2Y7wOm/92A2aAiGKD6ybUjp+xVB3BJb6hpW 3zQQKzfFo7xnDwvOBWGeKCfkKhxZdWJwHcKt+glTkOm4bJ0ZBvIrIfUO7uG/OGYC Vvs7cCBaf19vGlAGjjuMNmXh45XucY8JIq9MsP75iMAjqg0qyy5Z9LH/v2w4XNn9 yLVABV+sQnAeLg186Dm6wUdAVJJ9Becd0ukdUuv/UAL0HHVe5N+jR/QBI8nPGm8g == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 072E01027B; Thu, 2 Aug 2018 04:26:58 -0400 (EDT) From: Thomas Monjalon To: John Daley , Hyong Youb Kim Cc: dev@dpdk.org, ferruh.yigit@intel.com Date: Thu, 02 Aug 2018 10:26:54 +0200 Message-ID: <1580713.dMrMSxmPF2@xps> In-Reply-To: <20180726023028.23394-1-johndale@cisco.com> References: <20180726023028.23394-1-johndale@cisco.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/enic: revert support for mbuf fast free offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Aug 2018 08:27:01 -0000 26/07/2018 04:30, John Daley: > From: Hyong Youb Kim > > This reverts the patch that enabled mbuf fast free. > > There are two main reasons. > > First, enic_fast_free_wq_bufs is broken. When > DEV_TX_OFFLOAD_MBUF_FAST_FREE is enabled, the driver calls this > function to free transmitted mbufs. This function currently does not > reset next and nb_segs. This is simply wrong as the fast-free flag > does not imply anything about next and nb_segs. > > We could fix enic_fast_free_wq_bufs by making it to call > rte_pktmbuf_prefree_seg to reset the required fields. But, it negates > most of cycle saving. > > Second, there are customer applications that blindly enable all Tx > offloads supported by the device. Some of these applications do not > satisfy the requirements of mbuf fast free (i.e. a single pool per > queue and refcnt = 1), and end up crashing or behaving badly. > > Fixes: bcaa54c1a148 ("net/enic: support mbuf fast free offload") > > Signed-off-by: Hyong Youb Kim > Reviewed-by: John Daley Applied