From: Thomas Monjalon <thomas.monjalon@6wind.com> To: "Chen Jing D(Mark)" <jing.d.chen@intel.com> Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 5/6] i40e: macaddr add/del enhancement Date: Tue, 14 Oct 2014 16:25:04 +0200 Message-ID: <1581482.OfWWpU8tO6@xps13> (raw) In-Reply-To: <1411478047-1251-6-git-send-email-jing.d.chen@intel.com> 2014-09-23 21:14, Chen Jing D: > + PMD_DRV_LOG(ERR, "VMDQ not %s, can't set mac to pool %u\n", > + pf->flags | I40E_FLAG_VMDQ ? "configured" : "enabled", > + pool); [...] > - if (ret != I40E_SUCCESS) { > - PMD_DRV_LOG(ERR, "Failed to write mac address"); > + if (pool > pf->nb_cfg_vmdq_vsi) { > + PMD_DRV_LOG(ERR, "Pool number %u invalid. Max pool is %u\n", > + pool, pf->nb_cfg_vmdq_vsi); [...] > - PMD_DRV_LOG(ERR, "Failed to add MACVLAN filter"); > + PMD_DRV_LOG(ERR, "Failed to add MACVLAN filter\n"); [...] > + PMD_DRV_LOG(ERR, "Failed to remove MACVLAN filter\n"); I'm pretty sure you rebased this patch and solved the conflicts without updating your patch accordingly. Indeed carriage returns have been removed from logs recently. Hint: rebase conflicts are really often meaningful ;) -- Thomas
next prev parent reply other threads:[~2014-10-14 14:17 UTC|newest] Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-09-23 13:14 [dpdk-dev] [PATCH 0/6] i40e VMDQ support Chen Jing D(Mark) 2014-09-23 13:14 ` [dpdk-dev] [PATCH 1/6] ether: enhancement for " Chen Jing D(Mark) 2014-10-14 14:09 ` Thomas Monjalon 2014-10-15 6:59 ` Chen, Jing D 2014-10-15 8:10 ` Thomas Monjalon 2014-10-15 9:47 ` Chen, Jing D 2014-10-15 9:59 ` Thomas Monjalon 2014-10-16 10:07 ` [dpdk-dev] [PATCH v2 0/6] i40e " Chen Jing D(Mark) 2014-10-16 10:07 ` [dpdk-dev] [PATCH v2 1/6] ether: enhancement for " Chen Jing D(Mark) 2014-11-03 22:17 ` Thomas Monjalon 2014-11-04 5:50 ` Chen, Jing D 2014-11-04 8:53 ` Thomas Monjalon 2014-11-04 8:59 ` Chen, Jing D 2014-10-16 10:07 ` [dpdk-dev] [PATCH v2 2/6] igb: change for VMDQ arguments expansion Chen Jing D(Mark) 2014-11-03 18:37 ` Thomas Monjalon 2014-11-04 5:26 ` Chen, Jing D 2014-10-16 10:07 ` [dpdk-dev] [PATCH v2 3/6] ixgbe: " Chen Jing D(Mark) 2014-10-16 10:07 ` [dpdk-dev] [PATCH v2 4/6] i40e: add VMDQ support Chen Jing D(Mark) 2014-11-03 18:33 ` Thomas Monjalon 2014-11-04 5:22 ` Chen, Jing D 2014-10-16 10:07 ` [dpdk-dev] [PATCH v2 5/6] i40e: macaddr add/del enhancement Chen Jing D(Mark) 2014-10-16 10:07 ` [dpdk-dev] [PATCH v2 6/6] i40e: Add full VMDQ pools support Chen Jing D(Mark) 2014-10-21 3:30 ` [dpdk-dev] [PATCH v2 0/6] i40e VMDQ support Cao, Min 2014-11-03 7:54 ` Chen, Jing D 2014-11-04 10:01 ` [dpdk-dev] [PATCH v3 " Chen Jing D(Mark) 2014-11-04 10:01 ` [dpdk-dev] [PATCH v3 1/6] ether: enhancement for " Chen Jing D(Mark) 2014-11-04 10:01 ` [dpdk-dev] [PATCH v3 2/6] igb: change for VMDQ arguments expansion Chen Jing D(Mark) 2014-11-04 10:01 ` [dpdk-dev] [PATCH v3 3/6] ixgbe: " Chen Jing D(Mark) 2014-11-04 10:01 ` [dpdk-dev] [PATCH v3 4/6] i40e: add VMDQ support Chen Jing D(Mark) 2014-11-04 10:01 ` [dpdk-dev] [PATCH v3 5/6] i40e: macaddr add/del enhancement Chen Jing D(Mark) 2014-11-04 10:01 ` [dpdk-dev] [PATCH v3 6/6] i40e: Add full VMDQ pools support Chen Jing D(Mark) 2014-11-04 11:19 ` [dpdk-dev] [PATCH v3 0/6] i40e VMDQ support Ananyev, Konstantin 2014-11-04 23:17 ` Thomas Monjalon 2014-12-11 6:09 ` Cao, Min 2014-09-23 13:14 ` [dpdk-dev] [PATCH 2/6] igb: change for VMDQ arguments expansion Chen Jing D(Mark) 2014-09-23 13:14 ` [dpdk-dev] [PATCH 3/6] ixgbe: " Chen Jing D(Mark) 2014-09-23 13:14 ` [dpdk-dev] [PATCH 4/6] i40e: add VMDQ support Chen Jing D(Mark) 2014-10-13 16:14 ` De Lara Guarch, Pablo 2014-09-23 13:14 ` [dpdk-dev] [PATCH 5/6] i40e: macaddr add/del enhancement Chen Jing D(Mark) 2014-10-14 14:25 ` Thomas Monjalon [this message] 2014-10-15 7:01 ` Chen, Jing D 2014-09-23 13:14 ` [dpdk-dev] [PATCH 6/6] i40e: Add full VMDQ pools support Chen Jing D(Mark) 2014-10-10 10:45 ` [dpdk-dev] [PATCH 0/6] i40e VMDQ support Ananyev, Konstantin 2014-10-14 8:27 ` Chen, Jing D 2014-10-21 3:30 ` Cao, Min
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1581482.OfWWpU8tO6@xps13 \ --to=thomas.monjalon@6wind.com \ --cc=dev@dpdk.org \ --cc=jing.d.chen@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git