From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by dpdk.org (Postfix) with ESMTP id 680347E72 for ; Tue, 14 Oct 2014 16:17:39 +0200 (CEST) Received: by mail-wi0-f173.google.com with SMTP id fb4so10321234wid.0 for ; Tue, 14 Oct 2014 07:25:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=IjyYp6QFaA/cLvCKs/G+eSU1Vn5pnFdrkz9O9hjdGew=; b=mV+HJCav3ZSK9R+fu6XBqoVfkXt1aI9LEsD3QKBfay4k629Y0Ut6HRnUJZ6aafJjKZ YLLyzacQFxxuepwU59cVoCZyh6DTqfCLjhr7Zc7qvQWFVetaGsWIMffMz+lr/IZeWAxJ SmR+rFpLtpp14Db2Y2VkW+aHTbHfpaAieWAHQnyPenUnT/IrTuQT0i3E6zDybos5WHIy HFUERgBMJqFsfsqC6cD9e5bgHLFK85thsSDaBm4Ph0STEEXVLUkccf1v4fqk2kcrIcBK 2AXnOk+siZDpmpjoXPMIqANlwZOcys8lrBaNJaf1fJ46aZdyyhqetRtuqxi8yS4K8JBJ jbqA== X-Gm-Message-State: ALoCoQnK9hNkEI3hDde5CyxnYUL6a8XmvvCcG8yWyXq8IqmcH6lC/U/Rgc1hZHNZW1h3iIzRMXPZ X-Received: by 10.194.92.12 with SMTP id ci12mr5521162wjb.6.1413296723875; Tue, 14 Oct 2014 07:25:23 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id fm10sm8241354wib.21.2014.10.14.07.25.22 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Oct 2014 07:25:23 -0700 (PDT) From: Thomas Monjalon To: "Chen Jing D(Mark)" Date: Tue, 14 Oct 2014 16:25:04 +0200 Message-ID: <1581482.OfWWpU8tO6@xps13> Organization: 6WIND User-Agent: KMail/4.14.1 (Linux/3.16.4-1-ARCH; KDE/4.14.1; x86_64; ; ) In-Reply-To: <1411478047-1251-6-git-send-email-jing.d.chen@intel.com> References: <1411478047-1251-1-git-send-email-jing.d.chen@intel.com> <1411478047-1251-6-git-send-email-jing.d.chen@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 5/6] i40e: macaddr add/del enhancement X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Oct 2014 14:17:39 -0000 2014-09-23 21:14, Chen Jing D: > + PMD_DRV_LOG(ERR, "VMDQ not %s, can't set mac to pool %u\n", > + pf->flags | I40E_FLAG_VMDQ ? "configured" : "enabled", > + pool); [...] > - if (ret != I40E_SUCCESS) { > - PMD_DRV_LOG(ERR, "Failed to write mac address"); > + if (pool > pf->nb_cfg_vmdq_vsi) { > + PMD_DRV_LOG(ERR, "Pool number %u invalid. Max pool is %u\n", > + pool, pf->nb_cfg_vmdq_vsi); [...] > - PMD_DRV_LOG(ERR, "Failed to add MACVLAN filter"); > + PMD_DRV_LOG(ERR, "Failed to add MACVLAN filter\n"); [...] > + PMD_DRV_LOG(ERR, "Failed to remove MACVLAN filter\n"); I'm pretty sure you rebased this patch and solved the conflicts without updating your patch accordingly. Indeed carriage returns have been removed from logs recently. Hint: rebase conflicts are really often meaningful ;) -- Thomas