From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by dpdk.org (Postfix) with ESMTP id C0AC2C35A for ; Thu, 16 Apr 2015 11:18:44 +0200 (CEST) Received: by wiun10 with SMTP id n10so89531121wiu.1 for ; Thu, 16 Apr 2015 02:18:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=qcvXj1+ft92TtfoATXD6fxlEdTdvl6al5J3UGzMQclk=; b=Zwfk1CrGwhbpHzDkgnLGnUwMYMKUtKHjzEpWRLIsLzVxXTE3YrY2EEhV/s2OAOLbJH A1Aucp8OfQHqxCqk9dZ54W36dCwVfh67NkTcA+mSGpSUiC0IHFIosZp9+OVBpkQCYMWZ v9mYdrvErFGWiHca0aCXz72DPTEXUsqwlr1vpM5SA1P1OF7pTh4cAdJKdEDCUSXhOxFt jCNq10n19NVxs0/E4gJEn4m6D5F95QyzmS0sVGASCbVk/iPbAmZeaD7JP61r/585Bp4E hVkozD9qy9jzRNmAVeXg8w9Tskzlx8JpmErI+PwZGzh2oVjoFgFmhoi4OKRfo/ocAkLZ yo8A== X-Gm-Message-State: ALoCoQlD3/lw+xYJTKGIDyI9I5Zmv+GdUYBu9mMuCz3DVRDCIOTwOV0GiZr1hOS5BbBi8U5KD/ZG X-Received: by 10.194.179.194 with SMTP id di2mr57495202wjc.4.1429175924697; Thu, 16 Apr 2015 02:18:44 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id ew10sm13083689wic.22.2015.04.16.02.18.43 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Apr 2015 02:18:44 -0700 (PDT) Date: Thu, 16 Apr 2015 02:18:44 -0700 (PDT) X-Google-Original-Date: Thu, 16 Apr 2015 11:18 +0200 From: Thomas Monjalon To: Vlad Zolotarov Message-ID: <1581903.SRNWASATZe@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <552F7D85.2090002@cloudius-systems.com> References: <1958525.YbKd0lDtje@xps13> <1429130956-17828-1-git-send-email-thomas.monjalon@6wind.com> <552F7D85.2090002@cloudius-systems.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 1/2] ixgbe: fix build with gcc 4.4 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Apr 2015 09:18:45 -0000 2015-04-16 12:14, Vlad Zolotarov: > On 04/15/15 23:49, Thomas Monjalon wrote: > > The "may be used uninitialized" warning seems to be another GCC bug and is > > workarounded with NULL initialization. > > --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > > +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > > @@ -1476,8 +1476,8 @@ ixgbe_recv_pkts_lro(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts, > > bool eop; > > struct ixgbe_rx_entry *rxe; > > struct ixgbe_rsc_entry *rsc_entry; > > - struct ixgbe_rsc_entry *next_rsc_entry; > > - struct ixgbe_rx_entry *next_rxe; > > + struct ixgbe_rsc_entry *next_rsc_entry = NULL; > > + struct ixgbe_rx_entry *next_rxe = NULL; > > -Wno-maybe-uninitialized ? I prefer avoiding this flag for 2 reasons: - It's not supported in every GCC versions (need special handling) - NULL assigment doesn't hurt