From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 73E95A0556; Thu, 20 Feb 2020 15:42:29 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9CE804C81; Thu, 20 Feb 2020 15:42:28 +0100 (CET) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10049.outbound.protection.outlook.com [40.107.1.49]) by dpdk.org (Postfix) with ESMTP id 22DD225B3; Thu, 20 Feb 2020 15:42:28 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BfWBextRuehExzRI94A4dbBiHPtY4rFpwEFukTYPrlLkxlmq+MjG9Qf1BPVkmUwRNE1LKe+2BcJS8tHQINDtO6VdGc6hmAC0Onc0NwFF18FE8gdz6cvd8rZN/gUNLvEhHkyDQ4a62fHqIdl6a+rvE/8XiPwjredlFURrtbls8NTD70S4aeP4ae1ua+CDBJju9y+Yb742fUSqMuuom6nguKdZP3GViSTobWeA4vDiTi+mP+/DGZM5VhFYdOJVqI1SHHBX18lCU3wuIXspV13aW8Rzw7OPI8Z08ynakZS/MEQy+5oHJTcTqbck8exUa+W3SB+AYBXMvwPI7DMwq33Vxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iSKIQ1hSQmu4ww6wEdCNR2m2tNKBQvePvWDg7msEzOU=; b=Q6gNwSXJTB/SF0NHsh2iQiVs1Ow/AUPsiA5hZw11GoodapyyTAs/6kB8B8PIkXtKVgFC/iTB/KZmBSRIJE4nDvUnPBBRPx5VAGxuOIR3T55cVzokx/NAVIpkZE1D8qMjnOCQAewXhHYjebEPNIesompTXpy+6LtKj93zzVoosCytp+oawQoQb3JWCtmGaag0HjGeCwhmox3dWE/GCwB4vLs4nOWVxefaTgmTMT+KbJlWM1E+XNDSZTGsRyNhhmFg8HalSBMISvJGlY6aP5psr61H3Q8QNbh2fNcZGt0Rh8g1lBtDDDLysd3CU1/xXCMlrG0jrkYzceM/4ps2GeSINg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iSKIQ1hSQmu4ww6wEdCNR2m2tNKBQvePvWDg7msEzOU=; b=cbLYC5FDiVoVrnhtHjwefVhug4b4hUloiXmEK0ICpeYKpVHsq9vUhxoRmFZWVDyNcfprqyrYHv3cI3XEqO2JRDRKfWdD9sCKWpACDQJu6yYOMhRfxs5YDpr6kPo+fGz5Df/3UVcr1VzSYlFylVr6adPyONpxjykwC0PTerBzfy4= Received: from AM0PR0502MB3874.eurprd05.prod.outlook.com (52.133.45.29) by AM0PR0502MB3780.eurprd05.prod.outlook.com (52.133.45.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2750.18; Thu, 20 Feb 2020 14:42:26 +0000 Received: from AM0PR0502MB3874.eurprd05.prod.outlook.com ([fe80::500b:9d76:8f12:9cd7]) by AM0PR0502MB3874.eurprd05.prod.outlook.com ([fe80::500b:9d76:8f12:9cd7%7]) with mapi id 15.20.2729.033; Thu, 20 Feb 2020 14:42:26 +0000 Received: from mellanox.com (94.188.199.18) by ZR0P278CA0032.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2750.18 via Frontend Transport; Thu, 20 Feb 2020 14:42:25 +0000 From: Shiri Kuzin To: "dev@dpdk.org" CC: Matan Azrad , Raslan Darawsheh , Slava Ovsiienko , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix running without rxq Thread-Index: AQHV5/v4KMeDbzamUUmK0pSEKZ9n9Q== Date: Thu, 20 Feb 2020 14:42:26 +0000 Message-ID: <1582209716-26527-1-git-send-email-shirik@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: ZR0P278CA0032.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1c::19) To AM0PR0502MB3874.eurprd05.prod.outlook.com (2603:10a6:208:1a::29) authentication-results: spf=none (sender IP is ) smtp.mailfrom=shirik@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 1.8.3.1 x-originating-ip: [94.188.199.18] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: e9a42ca4-a41f-4409-9e47-08d7b6131a9e x-ms-traffictypediagnostic: AM0PR0502MB3780:|AM0PR0502MB3780: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:457; x-forefront-prvs: 031996B7EF x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(39850400004)(396003)(346002)(366004)(376002)(199004)(189003)(52116002)(7696005)(8676002)(26005)(186003)(81166006)(71200400001)(8936002)(16526019)(6916009)(8886007)(55016002)(81156014)(36756003)(66556008)(66446008)(450100002)(64756008)(316002)(956004)(2906002)(478600001)(5660300002)(86362001)(66946007)(66476007)(4326008)(2616005)(54906003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3780; H:AM0PR0502MB3874.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wvufSAoty7D9HN81qvivgS34pjW845mHPKM040EVE28DG9euIym2BSza1Muo4RYaBx8SPUUo5jbIVv+nOG3Lx1WNWZkEp8Zj7qjRTQXJd8qrRpgHbJj8SiyOu61FGzVCCcGdn+c+a7qk/uBGGcxYZhZ+eRVrG/16zb6ml36xq61sifs7WsSgdfiLzannF9b0snhti7/piEYytXa8L5RW5+KdgzN6+HppTrRZkZEmiCDyK8h74xVV33FXCzgtJqf3SmCaUwkAi7pTSvYF066Rg2QazNxm7zsZha+gVJtu2rvLbsqdpa9k0CNoUDLxxhBE+GPu/jR2T9Xe6JZoZ+dgXt6V+RAsmGu6bwhjqNS61gvkX3DMQlD8QdMwGt6lO9MP/M8Tkp4UcYQD3zh9nfTHWkgr7bFD8dsl+p2U6sPmmL0cFvEuHgmW961a3eaTgETB x-ms-exchange-antispam-messagedata: kAPAkDft9n68czSxbvXYwVraoT7m+gJjCiCczVg02+PJZQsDj2GkL5FBNXouONu02mwGByHjr0aIhx/EKtkq/KSFvq7sXhdGkNNYeK24CXEYm9f3QUKRZ8uH+eR56dnZoKJ7tOpnatvoNeYEocJf6w== Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: e9a42ca4-a41f-4409-9e47-08d7b6131a9e X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Feb 2020 14:42:26.5440 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: T/gNoVd21iLrsN+GGEfxJY85HLOvu5LiCGuh6Oa4APtQkp9/SptsqpWnymBo5YMn+c+G4MMjaHzmnsOsFDq5Ow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3780 Subject: [dpdk-dev] [PATCH] net/mlx5: fix running without rxq X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When running mlx5_dev_start in mlx5_ethdev the function calls mlx5_dev_configure_rss_reta in order to configure the rxq's. Before mlx5_dev_configure_rss_reta there isn't a check whether there are rxq's and if rxq's are 0 the function fails. For example, this command: /build/app/test-pmd/testpmd -n 4 -w 0000:08:00.0,rx_vec_en=3D0 -- --burst=3D64 --mbcache=3D512 -i --nb-cores=3D27 --txd=3D2048 --rxd=3D2= 048 --vxlan-gpe-port=3D6081 --mp-alloc=3Dxbuf --rxq 0 --forward-mode=3Dtxonly would fail. In order to fix this issue, we should call mlx5_dev_configure_rss_reta only if we have rxq's. Fixes: 63bd16292c3a ("net/mlx5: support RSS on hairpin") Cc: stable@dpdk.org Signed-off-by: Shiri Kuzin Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_trigger.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/net/mlx5/mlx5_trigger.c b/drivers/net/mlx5/mlx5_trigge= r.c index be47df5..571b7a0 100644 --- a/drivers/net/mlx5/mlx5_trigger.c +++ b/drivers/net/mlx5/mlx5_trigger.c @@ -280,11 +280,13 @@ rte_net_mlx5_dynf_inline_mask =3D 1UL << fine_inline; else rte_net_mlx5_dynf_inline_mask =3D 0; - ret =3D mlx5_dev_configure_rss_reta(dev); - if (ret) { - DRV_LOG(ERR, "port %u reta config failed: %s", - dev->data->port_id, strerror(rte_errno)); - return -rte_errno; + if (dev->data->nb_rx_queues > 0) { + ret =3D mlx5_dev_configure_rss_reta(dev); + if (ret) { + DRV_LOG(ERR, "port %u reta config failed: %s", + dev->data->port_id, strerror(rte_errno)); + return -rte_errno; + } } ret =3D mlx5_txq_start(dev); if (ret) { --=20 1.8.3.1