From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id ED7CA2BAB; Mon, 28 Jan 2019 01:50:59 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 8DEC92094D; Sun, 27 Jan 2019 19:50:59 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 27 Jan 2019 19:50:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=nLDz1MTCkurWZo6nxRH8Sm6QhdS096zjrOw0z0hQTCw=; b=YB0q90QgxOUn IYdRALNW9Hw4e29Da9vZaD8Wvk5kd3+6K8JzA81lWMt3gsL2RibAX2EX4grfj8sV R3VGcpyH9wAEFZ5smMYU73U5kcMibZYCgDd83SqpCsCThzWRXfQ6sI4wAiSH0eTs Ov4C2tMudA8RWVeROj5AvMQccmcIR9k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=nLDz1MTCkurWZo6nxRH8Sm6QhdS096zjrOw0z0hQT Cw=; b=WbN/SHvLSbMML9Js8odjd7nNI2FunsZw64p+/eBRDpRJRRUOr87WNT/4M mDmmLUjAHq3f65FK/4aP7oZvV3PZUiHEyq8RCyP4nzqsOzqPDoFWcXyFiQvGC/64 VBWEprpL6zpGisDBbotkuk5MaDBwO8qttUrrhoNxHoID9yWEZNgbqc9fItTWoc72 yFIewJo1K1Ea/VTtaoV/8jEGjC5ETWUZjCZ8as626aN+1Xx5NVPUACUjknNXHQZq /1+2ldiWwyA8keu6u5aVg6YvcKBO4SFmgaph+71B1/r/3S8APJY6AS7N4qPr/Rzt Xww4Cl9u+Xe6GGLueyI69yf5LG1+w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrieelgddvkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecufedt tdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufffkfgjfh gggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceo thhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfe drudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 87FB010087; Sun, 27 Jan 2019 19:50:57 -0500 (EST) From: Thomas Monjalon To: Luca Boccassi Cc: stable@dpdk.org, Bruce Richardson , "Gavin Hu (Arm Technology China)" , "dev@dpdk.org" , "christian.ehrhardt@canonical.com" , Honnappa Nagarahalli , "jerinj@marvell.com" Date: Mon, 28 Jan 2019 01:50:56 +0100 Message-ID: <15834031.ur9EiTGk5p@xps> In-Reply-To: <20190111095732.GA21328@bricha3-MOBL.ger.corp.intel.com> References: <20190110172806.12952-1-bluca@debian.org> <20190111095732.GA21328@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] build: mention -march in pkg-config description X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jan 2019 00:51:00 -0000 > > > Applications need to at least match DPDK's -march option to build > > > successfully due to some static inline functions in the public headers. > > > > > > This might cause problems, especially in distributions, so add a note > > > in the pkg-config description. > > > > > > Fixes: a25a650be5f0 ("build: add infrastructure for meson and ninja builds") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Luca Boccassi > > > --- > > > At the moment there are no adversely affected applications in Debian and > > > Ubuntu (collectd builds a separate shared object, and OVS/virtio-forwareder > > > are stand-alone DPDK-specific binaries), but we thought that having an > > > explicit notice would be good. > > > > > > --- a/meson.build > > > +++ b/meson.build > > > @@ -83,7 +83,9 @@ pkg.generate(name: meson.project_name(), > > > libraries: dpdk_libraries, > > > libraries_private: dpdk_drivers + dpdk_static_libraries + > > > ['-Wl,-Bdynamic'] + dpdk_extra_ldflags, > > > -description: 'The Data Plane Development Kit (DPDK)', > > > +description: '''The Data Plane Development Kit (DPDK). > > > +Note that CFLAGS might contain an -march flag higher than typical baseline. > > > +This is required for a number of static inline functions in the public > > From Arm's perspective, this notice is really necessary for some extensions like LSE to work for performance. > > Reviewed-by: Gavin Hu > > > No objection from me for more documentation. > > Acked-by: Bruce Richardson Applied, thanks