From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] vfio: Support for no-IOMMU mode
Date: Wed, 27 Jan 2016 10:05:04 +0100 [thread overview]
Message-ID: <1584319.QMRQbZMs1h@xps13> (raw)
In-Reply-To: <1452688569-14695-1-git-send-email-anatoly.burakov@intel.com>
Hi Anatoly,
Few small comments.
The comments "function pointer typedef" or "structure to hold" don't
bring new information. Please keep it short.
2016-01-13 12:36, Anatoly Burakov:
> +/* function pointer typedef for DMA mapping functions */
-> DMA mapping function type
It would be relevant to describe the return and the parameter.
> +typedef int (*vfio_dma_func_t)(int);
> +
> +/* Structure to hold supported IOMMU types */
This comment seems useless.
> +struct vfio_iommu_type {
[...]
> +/* function prototypes for different IOMMU types */
idem
> +int vfio_iommu_type1_dma_map(int container_fd);
> +int vfio_iommu_noiommu_dma_map(int container_fd);
> +
> +/* IOMMU types we support */
> +static const struct vfio_iommu_type iommu_types[] = {
> + /* x86 IOMMU, otherwise known as type 1 */
> + { VFIO_TYPE1_IOMMU, "Type 1", &vfio_iommu_type1_dma_map},
> + /* IOMMU-less mode */
> + { VFIO_NOIOMMU_IOMMU, "No-IOMMU", &vfio_iommu_noiommu_dma_map},
> +};
[...]
> --- /dev/null
> +++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio_dma.c
Why a new file for these functions?
next prev parent reply other threads:[~2016-01-27 9:06 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-21 20:16 [dpdk-dev] [PATCH] " Anatoly Burakov
2016-01-13 12:36 ` [dpdk-dev] [PATCH v2] " Anatoly Burakov
2016-01-13 16:45 ` Stephen Hemminger
2016-01-14 9:50 ` Burakov, Anatoly
2016-01-27 9:05 ` Thomas Monjalon [this message]
2016-01-27 10:08 ` Burakov, Anatoly
2016-01-27 10:12 ` Thomas Monjalon
2016-01-27 10:24 ` David Marchand
2016-01-27 10:29 ` Burakov, Anatoly
2016-01-27 14:04 ` [dpdk-dev] [PATCH v3] " Anatoly Burakov
2016-01-27 14:23 ` Burakov, Anatoly
2016-01-27 14:32 ` [dpdk-dev] [PATCH v4] " Anatoly Burakov
2016-01-27 15:50 ` Thomas Monjalon
2016-01-27 16:01 ` Burakov, Anatoly
2016-01-27 16:30 ` Burakov, Anatoly
2016-01-27 16:50 ` [dpdk-dev] [PATCH v5] " Anatoly Burakov
2016-01-27 17:07 ` Thomas Monjalon
2016-01-28 10:03 ` Burakov, Anatoly
2016-01-28 13:27 ` Thomas Monjalon
2016-01-28 11:57 ` [dpdk-dev] [PATCH v6] " Anatoly Burakov
2016-01-28 13:58 ` Thomas Monjalon
2016-01-28 14:16 ` Burakov, Anatoly
2016-01-28 14:40 ` Thomas Monjalon
2016-01-28 15:00 ` Burakov, Anatoly
2016-01-28 16:55 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1584319.QMRQbZMs1h@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).