Re: [dpdk-dev] [PATCH v3] doc: add performance test guide to the linux gsg

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2015-09-24 19:48, Qian Xu:
> --- a/doc/guides/linux_gsg/index.rst
> +++ b/doc/guides/linux_gsg/index.rst
> @@ -47,3 +47,4 @@ Contents
>      build_sample_apps
>      enable_func
>      quick_start
> +    perf_test_intel_platform_nic

Why "test"? What about nic_perf_intel_platform?

> --- /dev/null
> +++ b/doc/guides/linux_gsg/perf_test_intel_platform_nic.rst
[...]
> +Grub Boot Parameters
> +~~~~~~~~~~~~~~~~~~~~
> +
> +The following are some recommendations on GRUB boot settings:
> +
> +#. Use the default grub file as a starting point.
> +
> +#. Reserve 1G huge pages via grub configurations. For example to reserve 8 huge pages of 1G size::
> +
> +      default_hugepagesz=1G hugepagesz=1G hugepages=8
> +
> +#. Isolate CPU cores which will be used for DPDK. For example::
> +
> +      isolcpus=2,3,4,5,6,7,8
> +
> +#. If it wants to use VFIO, use the following additional grub parameters::
> +
> +      iommu=pt intel_iommu=on

These paramters can be set with GRUB, yes.
But they are Linux command line parameters.
I suggest to change the title.

[...]
> +4. Bind the test ports to igb_uio. For example bind two ports to a DPDK compatible driver and check the status:

Not speaking about VFIO here suggests that igb_uio gives better performance.
By the way, UIO/VFIO is not used by mlx4.

[...]
> +   Note: Don't use one 2 lcores on the same core

one 2 lcores? looks to be a typo

[...]
> +5. As it is known that a XL710 40G port need at least two queue pairs to achieve best performance,

Is it well known? At least it is said here.

> +8. Configure the traffic to a traffic generator such as IXIA or Spirent.
> +
> +   * Start creating a stream on packet generator, e.g. IXIA.

Not sure mentioning IXIA or Spirent helps here.
Same comment for the (nice) diagram.

Thanks for the documentation effort.