DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: stable@dpdk.org, David Marchand <david.marchand@redhat.com>,
	dev <dev@dpdk.org>, Anatoly Burakov <anatoly.burakov@intel.com>,
	Olivier Matz <olivier.matz@6wind.com>,
	Didier Pallard <didier.pallard@6wind.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] mem: ease init in a docker container
Date: Tue, 04 Jun 2019 13:05:51 +0200	[thread overview]
Message-ID: <1584930.Wu5a5yPRnN@xps> (raw)
In-Reply-To: <CAJFAV8wWqo+mFyYTinXVZQpaT9aeemmMMrgKhuzH6Gvhd3uZjA@mail.gmail.com>

23/05/2019 16:29, David Marchand:
> On Thu, May 23, 2019 at 11:53 AM Nicolas Dichtel <nicolas.dichtel@6wind.com>
> wrote:
> 
> > move_pages() is only used to get the numa node id, but this function
> > is not allowed by default in docker (it needs CAP_SYS_NICE and an update of
> > the seccomp profile).
> > get_mempolicy() also requires CAP_SYS_NICE but doesn't need any change in
> > the default seccomp profile.
> >
> > Note that the returned value of move_pages() was not checked, thus some
> > errors could be hidden (if the requested id was 0).
> >
> > Cc: stable@dpdk.org
> > Fixes: 582bed1e1d1d ("mem: support mapping hugepages at runtime")
> > Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> > Reviewed-by: Olivier Matz <olivier.matz@6wind.com>
> > Reviewed-by: Didier Pallard <didier.pallard@6wind.com>
> > Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
> Reviewed-by: David Marchand <david.marchand@redhat.com>

Applied, thanks Nico



      reply	other threads:[~2019-06-04 11:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-22 15:41 [dpdk-dev] [PATCH] librte_eal: " Nicolas Dichtel
2019-05-22 15:57 ` Burakov, Anatoly
2019-05-22 16:08   ` Nicolas Dichtel
2019-05-23  8:48     ` Burakov, Anatoly
2019-05-23  8:56 ` Burakov, Anatoly
2019-05-23  9:00   ` David Marchand
2019-05-23  9:52     ` [dpdk-dev] [PATCH v2] mem: " Nicolas Dichtel
2019-05-23 14:29       ` [dpdk-dev] [dpdk-stable] " David Marchand
2019-06-04 11:05         ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1584930.Wu5a5yPRnN@xps \
    --to=thomas@monjalon.net \
    --cc=anatoly.burakov@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=didier.pallard@6wind.com \
    --cc=nicolas.dichtel@6wind.com \
    --cc=olivier.matz@6wind.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).