DPDK patches and discussions
 help / color / mirror / Atom feed
From: Alexander Kozyrev <akozyrev@mellanox.com>
To: dev@dpdk.org
Cc: rasland@mellanox.com, matan@mellanox.com, viacheslavo@mellanox.com
Subject: [dpdk-dev] [PATCH 0/3] net/mlx5: add large packet size support to MPRQ
Date: Thu,  2 Apr 2020 18:11:45 +0000	[thread overview]
Message-ID: <1585851108-485-1-git-send-email-akozyrev@mellanox.com> (raw)
In-Reply-To: <1585691559-17409-1-git-send-email-akozyrev@mellanox.com>

In order to support the 9K MTU the MPRQ feature should be updated
to allow a packet to take more than one stride (single linear buffer).
Receiving a packet into multiple adjacent strides should be implemented.
The reason preventing the packet to be received into multiple strides is
that the data buffer must be preceded with some HEAD_ROOM space.
In the current implementation the HEAD_ROOM space is borrowed by the PMD
from the tail of the preceding stride. If packet takes multiple strides
the tail of stride may be overwritten with a packet data and the memory
can't be borrowed to provide the HEAD_ROOM space for the next packet.
Special care is needed to prevent the HEAD_ROOM corruption as such:
- copy a whole packet into a separate memory buffer if scatter is off
- copy an overlapping data only and craft a multi-segment mbuf otherwise
After multi-stride support for packets receiving is in place it is
possible to reduce the stride size for more efficient memory utilization.
Introduce the mprq_log_stride_size device parameter to configure
a stride size for MPRQ. Default stride size is set to 2048 bytes.

Signed-off-by: Alexander Kozyrev <akozyrev@mellanox.com>
---
v1: https://patchwork.dpdk.org/cover/67558/
v2: merge documentation and implementation in one commit

Alexander Kozyrev (3):
  net/mlx5: add a devarg to specify MPRQ stride size
  net/mlx5: enable MPRQ multi-stride operations
  net/mlx5: add multi-segment packets in MPRQ mode

 doc/guides/nics/mlx5.rst               |   9 +++
 doc/guides/rel_notes/release_20_05.rst |   1 +
 drivers/net/mlx5/mlx5.c                |  34 ++++++++--
 drivers/net/mlx5/mlx5.h                |   1 +
 drivers/net/mlx5/mlx5_defs.h           |   3 +
 drivers/net/mlx5/mlx5_rxq.c            |  47 ++++++--------
 drivers/net/mlx5/mlx5_rxtx.c           | 113 +++++++++++++++++++--------------
 drivers/net/mlx5/mlx5_rxtx.h           |   2 +-
 8 files changed, 128 insertions(+), 82 deletions(-)

-- 
1.8.3.1


  parent reply	other threads:[~2020-04-02 18:11 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-31 21:52 [dpdk-dev] [PATCH 0/4] " Alexander Kozyrev
2020-03-31 21:52 ` [dpdk-dev] [PATCH 1/4] net/mlx5: add a devarg to specify MPRQ stride size Alexander Kozyrev
2020-04-02 10:00   ` Slava Ovsiienko
2020-03-31 21:52 ` [dpdk-dev] [PATCH 2/4] net/mlx5: enable MPRQ multi-stride operations Alexander Kozyrev
2020-04-02 10:01   ` Slava Ovsiienko
2020-03-31 21:52 ` [dpdk-dev] [PATCH 3/4] doc: add a decsription for MPRQ stride size devarg Alexander Kozyrev
2020-03-31 21:52 ` [dpdk-dev] [PATCH 4/4] net/mlx5: add multi-segment packets in MPRQ mode Alexander Kozyrev
2020-04-02 10:02   ` Slava Ovsiienko
2020-04-02 18:11 ` Alexander Kozyrev [this message]
2020-04-02 18:11   ` [dpdk-dev] [PATCH 1/3] net/mlx5: add a devarg to specify MPRQ stride size Alexander Kozyrev
2020-04-02 18:11   ` [dpdk-dev] [PATCH 2/3] net/mlx5: enable MPRQ multi-stride operations Alexander Kozyrev
2020-04-02 18:11   ` [dpdk-dev] [PATCH 3/3] net/mlx5: add multi-segment packets in MPRQ mode Alexander Kozyrev
2020-04-09 22:23   ` [dpdk-dev] [PATCH v4 0/3] net/mlx5: add large packet size support to MPRQ Alexander Kozyrev
2020-04-09 22:23     ` [dpdk-dev] [PATCH v4 1/3] net/mlx5: add a devarg to specify MPRQ stride size Alexander Kozyrev
2020-04-14 11:42       ` Ferruh Yigit
2020-04-14 12:52         ` Thomas Monjalon
2020-04-15 11:01           ` Ferruh Yigit
2020-04-15 11:25             ` Luca Boccassi
2020-04-15 15:34               ` Alexander Kozyrev
2020-04-15 15:52                 ` [dpdk-dev] [dpdk-stable] " Luca Boccassi
2020-04-09 22:23     ` [dpdk-dev] [PATCH v4 2/3] net/mlx5: enable MPRQ multi-stride operations Alexander Kozyrev
2020-04-09 22:23     ` [dpdk-dev] [PATCH v4 3/3] net/mlx5: add multi-segment packets in MPRQ mode Alexander Kozyrev
2020-04-10 14:01     ` [dpdk-dev] [PATCH v4 0/3] net/mlx5: add large packet size support to MPRQ Matan Azrad
2020-04-13 10:57     ` Raslan Darawsheh
2020-04-09 21:24 ` [dpdk-dev] [PATCH v3 " Alexander Kozyrev
2020-04-09 21:24   ` [dpdk-dev] [PATCH v3 1/3] net/mlx5: add a devarg to specify MPRQ stride size Alexander Kozyrev
2020-04-09 21:24   ` [dpdk-dev] [PATCH v3 2/3] net/mlx5: enable MPRQ multi-stride operations Alexander Kozyrev
2020-04-09 21:24   ` [dpdk-dev] [PATCH v3 3/3] net/mlx5: add multi-segment packets in MPRQ mode Alexander Kozyrev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1585851108-485-1-git-send-email-akozyrev@mellanox.com \
    --to=akozyrev@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=matan@mellanox.com \
    --cc=rasland@mellanox.com \
    --cc=viacheslavo@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).