Re: [dpdk-dev] [PATCH] net/softnic: add support for service cores

[Thomas Monjalon <thomas@monjalon.net>]

10/01/2019 00:23, Thomas Monjalon:
> 07/01/2019 17:50, Dumitrescu, Cristian:
> > 
> > > -----Original Message-----
> > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Cristian Dumitrescu
> > > Sent: Thursday, January 3, 2019 4:05 PM
> > > To: dev@dpdk.org
> > > Cc: Singh, Jasvinder <jasvinder.singh@intel.com>
> > > Subject: [dpdk-dev] [PATCH] net/softnic: add support for service cores
> > > 
> > > Add support to run the Soft NIC device on service cores, based on the
> > > value of the sc parameter:
> > > 
> > > 0: The current Soft NIC device is run explicitly by the application. The
> > >    firmware creates one or several pipelines for this dev and maps them
> > >    to CPU cores that should not be service cores. The app is required to
> > >    call rte_pmd_softnic_run() to make this dev work.
> > > 
> > > 1 (default): The current device is run on the service cores transparently
> > >    to the app. The firmware creates one or several pipelines for this dev
> > >    current device and maps them to CPU cores that should be service cores.
> > >    Each of these service cores is calling rte_pmd_softnic_run()
> > >    in order to make this dev work with no app intervention.
> > > 
> > > Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> > > ---
> > 
> > Applied to next-qos tree, thanks!
> 
> It does not compile with 32-bit toolchain:
> 
> drivers/net/softnic/rte_eth_softnic_thread.c:140:28: error:
> cast between incompatible function types
> from ‘int (*)(uint16_t)’ {aka ‘int (*)(short unsigned int)’}
> to ‘int32_t (*)(void *)’ {aka ‘int (*)(void *)’}
>   service_params.callback = (rte_service_func)rte_pmd_softnic_run;
>                             ^
> 
> Fixing in-tree.

After a better look, I won't fix it myself because the simple fix
would be an API change.
It is removed from the pull in master for now, sorry.