From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id A2C351B5A9 for ; Thu, 10 Jan 2019 00:33:51 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 2FC5120EB0; Wed, 9 Jan 2019 18:33:51 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 09 Jan 2019 18:33:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=AQPj0OqcOsR5jzB9vXhhEj/TWkusXwxZKdf/XeE8neU=; b=PtxPVCglpGqx nwW2sFK5OiOefYdOTLqhdAxdqlgINQp6hrk6ImNU1eVEgCU/1nl4yZt5gWehGLUd B3h+f9rV2pYotEpD8bV9QTF1iH3H7fmP0rEyoPRXDDn00JhLJTdI2OFcwRpNdhzI ezQhqYSOJoNsNSam33vYGzKrvTiiKpA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=AQPj0OqcOsR5jzB9vXhhEj/TWkusXwxZKdf/XeE8n eU=; b=rUFL0wGGS/fIFLRhAeusIndcj3kaxA7k1g+9TlmzuDgUm4gTJ00by2/29 3t1C/ldq2eQLb+8At6XBQDLjqtl969IX8x91VMxR47VY4At3V4E0I140a+QAtW6P 1wy6nZodV6YiqxRmZ/Sik14W8zTAX1AQ8LQkeS8zqhV919o4+c4zqS5yoWymezHC fqXg8KqHPSON3BDurk/NjbrZ9/5OaLWaXwGam3GWDv+QZAkv31STEAcWmv8341ag zFQnnbVLdJcwyLmY8YNtb8fueNO9rgO5dBiQ22WQdeWv0qznzSW5QQX5bVxRbQJq 4764VXGnVEf6Rho3D0FkEpc6UCYZg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrfedvgdduudculddtuddrgedtkedrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 39883100BB; Wed, 9 Jan 2019 18:33:50 -0500 (EST) From: Thomas Monjalon To: "Dumitrescu, Cristian" Cc: dev@dpdk.org, "Singh, Jasvinder" Date: Thu, 10 Jan 2019 00:33:49 +0100 Message-ID: <1586050.tAD3Vr9LNU@xps> In-Reply-To: <2914445.tvFdG4jiG5@xps> References: <20190103160432.147027-1-cristian.dumitrescu@intel.com> <3EB4FA525960D640B5BDFFD6A3D891268E826F2A@IRSMSX108.ger.corp.intel.com> <2914445.tvFdG4jiG5@xps> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] net/softnic: add support for service cores X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jan 2019 23:33:52 -0000 10/01/2019 00:23, Thomas Monjalon: > 07/01/2019 17:50, Dumitrescu, Cristian: > >=20 > > > -----Original Message----- > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Cristian Dumitre= scu > > > Sent: Thursday, January 3, 2019 4:05 PM > > > To: dev@dpdk.org > > > Cc: Singh, Jasvinder > > > Subject: [dpdk-dev] [PATCH] net/softnic: add support for service cores > > >=20 > > > Add support to run the Soft NIC device on service cores, based on the > > > value of the sc parameter: > > >=20 > > > 0: The current Soft NIC device is run explicitly by the application. = The > > > firmware creates one or several pipelines for this dev and maps th= em > > > to CPU cores that should not be service cores. The app is required= to > > > call rte_pmd_softnic_run() to make this dev work. > > >=20 > > > 1 (default): The current device is run on the service cores transpare= ntly > > > to the app. The firmware creates one or several pipelines for this= dev > > > current device and maps them to CPU cores that should be service c= ores. > > > Each of these service cores is calling rte_pmd_softnic_run() > > > in order to make this dev work with no app intervention. > > >=20 > > > Signed-off-by: Cristian Dumitrescu > > > Signed-off-by: Jasvinder Singh > > > --- > >=20 > > Applied to next-qos tree, thanks! >=20 > It does not compile with 32-bit toolchain: >=20 > drivers/net/softnic/rte_eth_softnic_thread.c:140:28: error: > cast between incompatible function types > from =E2=80=98int (*)(uint16_t)=E2=80=99 {aka =E2=80=98int (*)(short unsi= gned int)=E2=80=99} > to =E2=80=98int32_t (*)(void *)=E2=80=99 {aka =E2=80=98int (*)(void *)=E2= =80=99} > service_params.callback =3D (rte_service_func)rte_pmd_softnic_run; > ^ >=20 > Fixing in-tree. After a better look, I won't fix it myself because the simple fix would be an API change. It is removed from the pull in master for now, sorry.