From: Thomas Monjalon <thomas@monjalon.net>
To: Dharmik Thakkar <dharmik.thakkar@arm.com>
Cc: dev@dpdk.org, "Wang, Yipeng1" <yipeng1.wang@intel.com>,
"Gobriel, Sameh" <sameh.gobriel@intel.com>,
"honnappa.nagarahalli@arm.com" <honnappa.nagarahalli@arm.com>,
"zhongdahulinfan@163.com" <zhongdahulinfan@163.com>
Subject: Re: [dpdk-dev] [PATCH v4 0/3] hash: fix bugs in 'free key with position'
Date: Thu, 09 May 2019 22:36:00 +0200 [thread overview]
Message-ID: <1586488.L0gfE9as30@xps> (raw)
In-Reply-To: <D2C4A16CA39F7F4E8E384D204491D7A673E5E973@ORSMSX104.amr.corp.intel.com>
09/05/2019 21:36, Wang, Yipeng1:
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> >09/05/2019 19:19, Dharmik Thakkar:
> >> This patch series solves 2 bugs reported on Bugzilla (bug-261) within
> >> the function rte_hash_free_key_with_postion(). It also adds a test case
> >> to catch similar bugs in the future.
> >>
> >> https://bugs.dpdk.org/show_bug.cgi?id=261
> >
> >Yipeng, Sameh, should it enter in 19.05-rc4?
> >Are you sure it does not break things more?
> >If yes, please give your ack.
> [Wang, Yipeng]
> Please go ahead Thomas, I reviewed the code and it will not break other things. The
> changes are refrained inside an experimental API function.
>
> I haven't done the meson build test though.
Applied, thanks
next prev parent reply other threads:[~2019-05-09 20:36 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 16:51 [dpdk-dev] [PATCH 0/2] " Dharmik Thakkar
2019-05-08 16:51 ` Dharmik Thakkar
2019-05-08 16:51 ` [dpdk-dev] [PATCH 1/2] " Dharmik Thakkar
2019-05-08 16:51 ` Dharmik Thakkar
2019-05-08 16:51 ` [dpdk-dev] [PATCH 2/2] test/hash: add test for " Dharmik Thakkar
2019-05-08 16:51 ` Dharmik Thakkar
2019-05-08 20:11 ` Wang, Yipeng1
2019-05-08 20:11 ` Wang, Yipeng1
2019-05-08 22:54 ` Dharmik Thakkar
2019-05-08 22:54 ` Dharmik Thakkar
2019-05-08 22:59 ` [dpdk-dev] [PATCH v2 0/2] hash: fix bugs in " Dharmik Thakkar
2019-05-08 22:59 ` Dharmik Thakkar
2019-05-08 22:59 ` [dpdk-dev] [PATCH v2 1/2] " Dharmik Thakkar
2019-05-08 22:59 ` Dharmik Thakkar
2019-05-09 8:29 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-05-09 8:29 ` Thomas Monjalon
2019-05-09 10:40 ` 胡林帆
2019-05-09 10:40 ` 胡林帆
2019-05-09 11:25 ` Thomas Monjalon
2019-05-09 11:25 ` Thomas Monjalon
2019-05-09 12:38 ` Dharmik Thakkar
2019-05-09 12:38 ` Dharmik Thakkar
2019-05-08 22:59 ` [dpdk-dev] [PATCH v2 2/2] test/hash: add test for " Dharmik Thakkar
2019-05-08 22:59 ` Dharmik Thakkar
2019-05-09 13:39 ` [dpdk-dev] [PATCH v3 0/3] hash: fix bugs in " Dharmik Thakkar
2019-05-09 13:39 ` Dharmik Thakkar
2019-05-09 13:39 ` [dpdk-dev] [PATCH v3 1/3] hash: fix position bug " Dharmik Thakkar
2019-05-09 13:39 ` Dharmik Thakkar
2019-05-09 15:48 ` Wang, Yipeng1
2019-05-09 15:48 ` Wang, Yipeng1
2019-05-09 17:25 ` Dharmik Thakkar
2019-05-09 17:25 ` Dharmik Thakkar
2019-05-09 13:39 ` [dpdk-dev] [PATCH v3 2/3] hash: fix total entries in free key with position Dharmik Thakkar
2019-05-09 13:39 ` Dharmik Thakkar
2019-05-09 13:39 ` [dpdk-dev] [PATCH v3 3/3] test/hash: add test for 'free key with position' Dharmik Thakkar
2019-05-09 13:39 ` Dharmik Thakkar
2019-05-09 17:19 ` [dpdk-dev] [PATCH v4 0/3] hash: fix bugs in " Dharmik Thakkar
2019-05-09 17:19 ` Dharmik Thakkar
2019-05-09 17:19 ` [dpdk-dev] [PATCH v4 1/3] hash: fix position bug " Dharmik Thakkar
2019-05-09 17:19 ` Dharmik Thakkar
2019-05-09 19:27 ` Wang, Yipeng1
2019-05-09 19:27 ` Wang, Yipeng1
2019-05-09 20:14 ` Dharmik Thakkar
2019-05-09 20:14 ` Dharmik Thakkar
2019-05-09 20:23 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-05-09 20:23 ` Thomas Monjalon
2019-05-09 20:30 ` Dharmik Thakkar
2019-05-09 20:30 ` Dharmik Thakkar
2019-05-09 17:19 ` [dpdk-dev] [PATCH v4 2/3] hash: fix total entries in free key with position Dharmik Thakkar
2019-05-09 17:19 ` Dharmik Thakkar
2019-05-09 19:32 ` Wang, Yipeng1
2019-05-09 19:32 ` Wang, Yipeng1
2019-05-09 17:19 ` [dpdk-dev] [PATCH v4 3/3] test/hash: add test for 'free key with position' Dharmik Thakkar
2019-05-09 17:19 ` Dharmik Thakkar
2019-05-09 19:33 ` Wang, Yipeng1
2019-05-09 19:33 ` Wang, Yipeng1
2019-05-09 19:24 ` [dpdk-dev] [PATCH v4 0/3] hash: fix bugs in " Thomas Monjalon
2019-05-09 19:24 ` Thomas Monjalon
2019-05-09 19:36 ` Wang, Yipeng1
2019-05-09 19:36 ` Wang, Yipeng1
2019-05-09 20:36 ` Thomas Monjalon [this message]
2019-05-09 20:36 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1586488.L0gfE9as30@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=dharmik.thakkar@arm.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=sameh.gobriel@intel.com \
--cc=yipeng1.wang@intel.com \
--cc=zhongdahulinfan@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).