From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4B8ADA0599; Fri, 10 Apr 2020 07:20:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F233C1C2F6; Fri, 10 Apr 2020 07:20:30 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 1A5971C297; Fri, 10 Apr 2020 07:20:28 +0200 (CEST) IronPort-SDR: N7Qr8+BRPh9Oz7SuDvdMfM0iiT0BUltUOiHs0UhGXem8pTQUSl4lj+YANPJtUR8c/hUBq3Ng+V r2a7V88y9HKw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2020 22:20:27 -0700 IronPort-SDR: e59rXsIDJo10zMgP/24g4Gn0OVE6mfB2tapAPH9IzQvXpIGTn/83Nv5GmCnZI2pA8J/qVE4Nj5 fll/zsbk1ASA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,364,1580803200"; d="scan'208";a="331084053" Received: from unknown (HELO localhost.localdomain.localdomain) ([10.240.183.160]) by orsmga001.jf.intel.com with ESMTP; 09 Apr 2020 22:20:26 -0700 From: taox.zhu@intel.com To: konstantin.ananyev@intel.com wenzhuo.lu@intel.com xiaolong.ye@intel.com Cc: dev@dpdk.org konstantin.ananyev@intel.com martin.weiser@allegro-packets.com, "Zhu, Tao" , stable@dpdk.org Date: Fri, 10 Apr 2020 01:18:15 -0400 Message-Id: <1586495895-9610-1-git-send-email-taox.zhu@intel.com> X-Mailer: git-send-email 1.8.3.1 Subject: [dpdk-dev] [PATCH] net/ixgbe: fix resource leak after thread exits normally X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: "Zhu, Tao" When the thread exits normally, pthread_join() is not called, which can result in a resource leak. Therefore, the thread is set to separation mode using function pthread_detach(), so that no program call pthread_join() is required to recycle, and when the thread exits, the system automatically reclaims resources. Fixes: 819d0d1d57f1 ("net/ixgbe: fix blocking system events") Cc: stable@dpdk.org Signed-off-by: Zhu Tao --- drivers/net/ixgbe/ixgbe_ethdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 2c57976..f141ae4 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -4165,11 +4165,9 @@ static int ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev, ixgbe_dev_cancel_link_thread(struct rte_eth_dev *dev) { struct ixgbe_adapter *ad = dev->data->dev_private; - void *retval; if (!ixgbe_dev_wait_setup_link_complete(dev)) { pthread_cancel(ad->link_thread_tid); - pthread_join(ad->link_thread_tid, &retval); rte_atomic32_clear(&ad->link_thread_running); PMD_DRV_LOG(ERR, "Link thread not complete, cancel it!"); } @@ -4186,6 +4184,7 @@ static int ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev, u32 speed; bool autoneg = false; + pthread_detach(pthread_self()); speed = hw->phy.autoneg_advertised; if (!speed) ixgbe_get_link_capabilities(hw, &speed, &autoneg); -- 1.8.3.1