From: Mohsin Shaikh <mohsinshaikh@niometrics.com>
To: dev@dpdk.org
Cc: stable@dpdk.org, akozyrev@mellanox.com,
Mohsin Shaikh <mohsinshaikh@niometrics.com>
Subject: [dpdk-dev] [PATCH v2] net/mlx5: Allow configuring mlx5 port for TX only
Date: Mon, 13 Apr 2020 22:47:22 +0800 [thread overview]
Message-ID: <1586789242-9984-1-git-send-email-mohsinshaikh@niometrics.com> (raw)
In-Reply-To: <1586783744-8962-1-git-send-email-mohsinshaikh@niometrics.com>
Configuring mlx5 port with 0 rx rings and 1 or more tx rings causes
following error in dev_start:
net_mlx5: port 1 cannot allocate RSS queue list (0)
net_mlx5: port 1 reta config failed: Cannot allocate memory
Skip mlx5_dev_configure_rss_reta() when there are no rx rings.
Cc: stable@dpdk.org
Signed-off-by: Mohsin Shaikh <mohsinshaikh@niometrics.com>
---
v2: Fix coding style issue COMMIT_LOG_LONG_LINE
---
drivers/net/mlx5/mlx5_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c
index d7d3bc7..1d443c1 100644
--- a/drivers/net/mlx5/mlx5_ethdev.c
+++ b/drivers/net/mlx5/mlx5_ethdev.c
@@ -463,7 +463,7 @@ struct ethtool_link_settings {
unsigned int *rss_queue_arr = NULL;
unsigned int rss_queue_n = 0;
- if (priv->skip_default_rss_reta)
+ if (priv->skip_default_rss_reta || !rxqs_n)
return ret;
rss_queue_arr = rte_malloc("", rxqs_n * sizeof(unsigned int), 0);
if (!rss_queue_arr) {
--
1.8.3.1
next prev parent reply other threads:[~2020-04-13 14:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 13:15 [dpdk-dev] [PATCH] " Mohsin Shaikh
2020-04-13 14:47 ` Mohsin Shaikh [this message]
2020-04-13 18:50 ` [dpdk-dev] [PATCH v2] " Alexander Kozyrev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1586789242-9984-1-git-send-email-mohsinshaikh@niometrics.com \
--to=mohsinshaikh@niometrics.com \
--cc=akozyrev@mellanox.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).