From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 7F4F8A0577;
Tue, 14 Apr 2020 10:17:22 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 8361F1C2A0;
Tue, 14 Apr 2020 10:14:27 +0200 (CEST)
Received: from mail-pj1-f66.google.com (mail-pj1-f66.google.com
[209.85.216.66]) by dpdk.org (Postfix) with ESMTP id BA32A1C24B
for <dev@dpdk.org>; Tue, 14 Apr 2020 10:14:24 +0200 (CEST)
Received: by mail-pj1-f66.google.com with SMTP id t40so4899659pjb.3
for <dev@dpdk.org>; Tue, 14 Apr 2020 01:14:24 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google;
h=from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding;
bh=lhUKNr4BQDS/JwGej21/sv8hNab8o984cmrf4FSZAmY=;
b=PBCuXKY0vT6ELavCiiSdJdaEp9V5UDC5Ue5LjkRz2BTIldxbNX9rQDYBfb9PU3LYcq
oZJoUqt+TV9aeY+R4cNl7tkrsZNyqp0flMHTeDbRjpFOLwt7wPCPVlhffjD7aMz4gQbJ
K2lbYKoByEYjd+kLZKOMfMFPJ8ZbwS1zr1Q6w=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=lhUKNr4BQDS/JwGej21/sv8hNab8o984cmrf4FSZAmY=;
b=d7TqCDwQqvB000c0h71QW4uycNwMXmeDRHWzOUMGmqub0mPQvRUh11LV1R1k+cK3UX
ktUYMJpVdknCtC++1Pj8WcgebJRL+i5gJ5whvMspb85Y9Fa/FMIqk6VozeEhaTp7VNs9
i9LA44gqmzsMxA2NygXuRZRe2az0dIK/cHeuseeq96rPcQCrZXWaGQP5yVtGGcoCjVqV
52LJbhxevWy/NFRN8yEdJfXGoxW7CTN4jAWpPiHp9J9C0o4qg7JFt19urp0dmtlZE7To
H7/9crr+wj7zPfF945OHhRh8/viIXSdG77uNfryTenQnj+EyYIIgy4smye57SZYguUJY
gjTg==
X-Gm-Message-State: AGi0PuZvyR+MB8f+5WKoNYfIIRvs2OAMcD4A5w0nZUptu2i2Zfd9ZRb6
+b7/FR7EUmZWJrkt+YqYCNznh7P3FRV4FDcr6eJL1r9QkaxL7Aq5r6c2OhtjsgE5hmwA/9zEuuQ
c7SpiJOK8jKs+jqL4czy/Nli2qDdTtMCa1JO0CkzqZGIiBpthXkxuvnQVL1e+dko6KwRO
X-Google-Smtp-Source: APiQypJTmiknCuAbWxlPBkFhYddYV5E1ZgW4OVFLvR6tSKOpxocIsCkL516r1WMf22rPqgJxr/fzNg==
X-Received: by 2002:a17:90a:be12:: with SMTP id
a18mr8954851pjs.162.1586852063464;
Tue, 14 Apr 2020 01:14:23 -0700 (PDT)
Received: from S60.dhcp.broadcom.net ([192.19.234.250])
by smtp.gmail.com with ESMTPSA id e196sm671176pfh.43.2020.04.14.01.14.21
(version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
Tue, 14 Apr 2020 01:14:22 -0700 (PDT)
From: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>
To: dev@dpdk.org
Cc: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>
Date: Tue, 14 Apr 2020 13:43:12 +0530
Message-Id: <1586852011-37536-16-git-send-email-venkatkumar.duvvuru@broadcom.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1586852011-37536-1-git-send-email-venkatkumar.duvvuru@broadcom.com>
References: <1586806811-21736-1-git-send-email-venkatkumar.duvvuru@broadcom.com>
<1586852011-37536-1-git-send-email-venkatkumar.duvvuru@broadcom.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: [dpdk-dev] [PATCH v3 15/34] net/bnxt: add devargs parameter for
host memory based TRUFLOW feature
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
This feature can be enabled by passing
"-w 0000:0d:00.0,host-based-truflow=1” to the DPDK application.
Signed-off-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
---
drivers/net/bnxt/bnxt.h | 4 ++-
drivers/net/bnxt/bnxt_ethdev.c | 73 ++++++++++++++++++++++++++++++++++++++++++
2 files changed, 76 insertions(+), 1 deletion(-)
diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h
index c4507f7..cd84ebd 100644
--- a/drivers/net/bnxt/bnxt.h
+++ b/drivers/net/bnxt/bnxt.h
@@ -685,7 +685,9 @@ struct bnxt {
#define BNXT_SVIF_INVALID 0xFFFF
uint16_t func_svif;
uint16_t port_svif;
- struct tf tfp;
+
+ struct tf tfp;
+ uint8_t truflow;
};
int bnxt_mtu_set_op(struct rte_eth_dev *eth_dev, uint16_t new_mtu);
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 57ed90f..c4bbf1d 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -12,6 +12,7 @@
#include <rte_malloc.h>
#include <rte_cycles.h>
#include <rte_alarm.h>
+#include <rte_kvargs.h>
#include "bnxt.h"
#include "bnxt_filter.h"
@@ -126,6 +127,18 @@ static const struct rte_pci_id bnxt_pci_id_map[] = {
DEV_RX_OFFLOAD_SCATTER | \
DEV_RX_OFFLOAD_RSS_HASH)
+#define BNXT_DEVARG_TRUFLOW "host-based-truflow"
+static const char *const bnxt_dev_args[] = {
+ BNXT_DEVARG_TRUFLOW,
+ NULL
+};
+
+/*
+ * truflow == false to disable the feature
+ * truflow == true to enable the feature
+ */
+#define BNXT_DEVARG_TRUFLOW_INVALID(truflow) ((truflow) > 1)
+
static int bnxt_vlan_offload_set_op(struct rte_eth_dev *dev, int mask);
static void bnxt_print_link_info(struct rte_eth_dev *eth_dev);
static int bnxt_dev_uninit(struct rte_eth_dev *eth_dev);
@@ -4854,6 +4867,63 @@ static int bnxt_init_resources(struct bnxt *bp, bool reconfig_dev)
}
static int
+bnxt_parse_devarg_truflow(__rte_unused const char *key,
+ const char *value, void *opaque_arg)
+{
+ struct bnxt *bp = opaque_arg;
+ unsigned long truflow;
+ char *end = NULL;
+
+ if (!value || !opaque_arg) {
+ PMD_DRV_LOG(ERR,
+ "Invalid parameter passed to truflow devargs.\n");
+ return -EINVAL;
+ }
+
+ truflow = strtoul(value, &end, 10);
+ if (end == NULL || *end != '\0' ||
+ (truflow == ULONG_MAX && errno == ERANGE)) {
+ PMD_DRV_LOG(ERR,
+ "Invalid parameter passed to truflow devargs.\n");
+ return -EINVAL;
+ }
+
+ if (BNXT_DEVARG_TRUFLOW_INVALID(truflow)) {
+ PMD_DRV_LOG(ERR,
+ "Invalid value passed to truflow devargs.\n");
+ return -EINVAL;
+ }
+
+ bp->truflow = truflow;
+ if (bp->truflow)
+ PMD_DRV_LOG(INFO, "Host-based truflow feature enabled.\n");
+
+ return 0;
+}
+
+static void
+bnxt_parse_dev_args(struct bnxt *bp, struct rte_devargs *devargs)
+{
+ struct rte_kvargs *kvlist;
+
+ if (devargs == NULL)
+ return;
+
+ kvlist = rte_kvargs_parse(devargs->args, bnxt_dev_args);
+ if (kvlist == NULL)
+ return;
+
+ /*
+ * Handler for "truflow" devarg.
+ * Invoked as for ex: "-w 0000:00:0d.0,host-based-truflow=1”
+ */
+ rte_kvargs_process(kvlist, BNXT_DEVARG_TRUFLOW,
+ bnxt_parse_devarg_truflow, bp);
+
+ rte_kvargs_free(kvlist);
+}
+
+static int
bnxt_dev_init(struct rte_eth_dev *eth_dev)
{
struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(eth_dev);
@@ -4879,6 +4949,9 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev)
bp = eth_dev->data->dev_private;
+ /* Parse dev arguments passed on when starting the DPDK application. */
+ bnxt_parse_dev_args(bp, pci_dev->device.devargs);
+
bp->flags &= ~BNXT_FLAG_RX_VECTOR_PKT_MODE;
if (bnxt_vf_pciid(pci_dev->id.device_id))
--
2.7.4