From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 43FCF4C9F for ; Wed, 12 Sep 2018 17:00:28 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3E6A321E44; Wed, 12 Sep 2018 11:00:27 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 12 Sep 2018 11:00:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=6pGT/OBNQcYp7AaKsG5cR7LwXt QxWZUS6z6XWTFIwww=; b=s8LBTLOKCsPimmKs5XBoCKULOKTotc4+iZQuRahDnY CV5yTlxUKNVCFi0yCPKxJpTyH1ED+DE+44yuH2EMjnUNmX2yvdPPSvraQiaaAJYP U0Cswzk9be5eMRhZIIa5Msv4s52lXEiSi3yre10MOS/f7RJIgrvefvrlg3tkoh9J A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=6pGT/O BNQcYp7AaKsG5cR7LwXtQxWZUS6z6XWTFIwww=; b=DtQ3iicaThoWRZo2zex6Yt k2is5u9pFulby/FBMqQgi9o0aXPKWOTpCyFQk4dlBnX4tuKZWZ0HGmU484EB3XHp houSiLW2qeF69WScf3QJPA4uxkq+f7WVwYKjprexWnviwVOEgao1ddW6G/v403IW NZMHTwf+55pC8ibGKb9MhKj8JwwXZUZB36sC80rsWw8Hdu8BbTZU4ycGaabLoJOI bjXYnKNC0GRm5+YjHDyhm2ymr4WP2H48SG3OS7Xba8e/iQAttGZc+mAJOCwOlHx6 vT5eJwLbuOciMiY3z+EElx7UnMnwfnOf8mFWfJwXwUrwA/pMO/DHubX2hIa/q5fw == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C36E4102D5; Wed, 12 Sep 2018 11:00:25 -0400 (EDT) From: Thomas Monjalon To: Raslan Darawsheh Cc: jingjing.wu@intel.com, dev@dpdk.org, shahafs@mellanox.com, xuemingl@mellanox.com Date: Wed, 12 Sep 2018 17:00:34 +0200 Message-ID: <1587053.xzp1NJBhG1@xps> In-Reply-To: <1536739583-29166-1-git-send-email-rasland@mellanox.com> References: <1536739583-29166-1-git-send-email-rasland@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/2] app/testpmd: add a generic way for dumping packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Sep 2018 15:00:28 -0000 12/09/2018 10:06, Raslan Darawsheh: > verbosity for the received/sent packets is needed in all of the > forwarding engines so moving it to be in a separate function. > > Signed-off-by: Raslan Darawsheh > --- > app/test-pmd/Makefile | 1 + > app/test-pmd/testpmd.h | 2 + > app/test-pmd/util.c | 143 +++++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 146 insertions(+) If you are moving code from app/test-pmd/rxonly.c, you should update this file in the same patch, so it will appear more clearly as a move. Then the second patch would be only about adding the feature to more engines.