From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CC08AA058A; Fri, 17 Apr 2020 09:24:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 182401DDE9; Fri, 17 Apr 2020 09:23:39 +0200 (CEST) Received: from git-send-mailer.rdmz.labs.mlnx (unknown [37.142.13.130]) by dpdk.org (Postfix) with ESMTP id 8CDEE1DD7A for ; Fri, 17 Apr 2020 09:23:37 +0200 (CEST) From: Bing Zhao To: orika@mellanox.com, viacheslavo@mellanox.com, rasland@mellanox.com Cc: matan@mellanox.com, dev@dpdk.org Date: Fri, 17 Apr 2020 15:23:30 +0800 Message-Id: <1587108210-454878-1-git-send-email-bingz@mellanox.com> X-Mailer: git-send-email 1.8.3.1 Subject: [dpdk-dev] [PATCH] net/mlx5: fix missing Rx queue flags clear X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" After inserting an offload flow, the software flag information will be updated based on the flow. When receiving a packet on this queue, the hardware packet type bits and the software flag will be used together to get the inner packet and tunnel header type (if any) from the global packet type table. When destroying a flow, the corresponding Rx queue flag needs to be updated. All flags should be cleared when closing a device because all control flows and application flows are invalid anymore. Such behavior is missed when implementing the non-cached mode. Fixes: e1f94d51b8f7 ("net/mlx5: change operations for non-cached flows") Signed-off-by: Bing Zhao Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index c529aa3..bb7fb1e 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -4653,6 +4653,7 @@ struct rte_flow * mlx5_flow_stop_default(struct rte_eth_dev *dev) { flow_mreg_del_default_copy_action(dev); + flow_rxq_flags_clear(dev); } /** -- 1.8.3.1