DPDK patches and discussions
 help / color / mirror / Atom feed
From: Suanming Mou <suanmingm@mellanox.com>
To: viacheslavo@mellanox.com, matan@mellanox.com
Cc: rasland@mellanox.com, dev@dpdk.org
Subject: [dpdk-dev] [PATCH 1/2] net/mlx5: fix incorrect indexed pool configurations
Date: Mon, 20 Apr 2020 10:34:35 +0800	[thread overview]
Message-ID: <1587350076-58468-2-git-send-email-suanmingm@mellanox.com> (raw)
In-Reply-To: <1587350076-58468-1-git-send-email-suanmingm@mellanox.com>

The indexed pool configurations of mark reg copy and hrxq are incorrect.

The incorrect pool trunk size which assigned the meter struct size to
mark reg copy pool will caused wrong memory entry allocated.

The incorrect pool type makes the hrxq pool seems be confusing.

Fixes: a339b088298d ("net/mlx5: convert hrxq to indexed")
Fixes: 6cb8de0a5ad0 ("net/mlx5: convert mark copy resource to indexed")

Signed-off-by: Suanming Mou <suanmingm@mellanox.com>
---
 drivers/net/mlx5/mlx5.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index a83791c..cc13e44 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -268,7 +268,7 @@ struct mlx5_dev_spawn_data {
 		.type = "mlx5_meter_ipool",
 	},
 	{
-		.size = sizeof(struct mlx5_flow_meter),
+		.size = sizeof(struct mlx5_flow_mreg_copy_resource),
 		.trunk_size = 64,
 		.grow_trunk = 3,
 		.grow_shift = 2,
@@ -287,7 +287,7 @@ struct mlx5_dev_spawn_data {
 		.release_mem_en = 1,
 		.malloc = rte_malloc_socket,
 		.free = rte_free,
-		.type = "mlx5_jump_ipool",
+		.type = "mlx5_hrxq_ipool",
 	},
 	{
 		.size = sizeof(struct mlx5_flow_handle),
-- 
1.8.3.1


  reply	other threads:[~2020-04-20  2:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-20  2:34 [dpdk-dev] [PATCH 0/2] net/mlx5: fix indexed pool bugs Suanming Mou
2020-04-20  2:34 ` Suanming Mou [this message]
2020-04-20  2:34 ` [dpdk-dev] [PATCH 2/2] net/mlx5: fix indexed pool incorrect trunks free Suanming Mou
2020-04-20 13:15 ` [dpdk-dev] [PATCH 0/2] net/mlx5: fix indexed pool bugs Raslan Darawsheh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1587350076-58468-2-git-send-email-suanmingm@mellanox.com \
    --to=suanmingm@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=matan@mellanox.com \
    --cc=rasland@mellanox.com \
    --cc=viacheslavo@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).