From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09CE6A0353; Tue, 5 Nov 2019 14:09:44 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 905A84CA6; Tue, 5 Nov 2019 14:09:43 +0100 (CET) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id 20DB04C9D for <dev@dpdk.org>; Tue, 5 Nov 2019 14:09:42 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 518A36CB6; Tue, 5 Nov 2019 08:09:41 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 05 Nov 2019 08:09:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=1K95z+L0+tCOraXxkxQM2DcgVeeOYC/C5X98LTt2TUQ=; b=Jeh2g+JMt373 3NCClhOAxON1xu/u3PtV8HXmuifEZrdEIzqOSJoSpyCkwFgGXBsWQbwYtqN1XMij tb2aDAioConJkkosBQ3f4INiQNB2iloBZ7qB50+Zjx/aTdugUYAQQbU69rg6pt3I eCFYf2w+xoO27evpiS/dhnpU8eWmcP8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=1K95z+L0+tCOraXxkxQM2DcgVeeOYC/C5X98LTt2T UQ=; b=ynSc7VxwfNJs1g7UcRu0u1BHZRO3mQLj/+0NmvHvzpiollsGGHqwKIM18 9yCigE6LSmAeHEqycY7cBF5QOwPkQ2ldv7rVl3jW9A5oGF7O1oyzCRjXPXbw43PE chUsZORo5sZ7u+sRzfMzl/xv8fhYd0eNNHi7Ddwm5kmooO0C+P3QPku9Xd74c3hl MKu2yKRTsfoqffGXWGxfPlHEy3ovXOSyZEEaImbulIbvPuar1sZvp8N3ePlLo/I6 R1M/zPUcA3gVrNf63e3yHbaZFGdnzqe3OQTenfxjyJth2lqmTKXpClraECc3EiUN +64Hndgn66a1ffCgVRljhTZZZjWGQ== X-ME-Sender: <xms:k3TBXdeV5U9rHgWII0xox74UycIU79dDKw1OkBiz94xJC7MyHxt8mg> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudduhedggeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeelfedrvdefrddvhedurddvtddtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: <xmx:k3TBXXFFl7kn_-vWO4yBIcwcVQECKDRhZxVFWuG0tzmztBRrkXR-Cw> <xmx:k3TBXSD-C_mrS0l5AjBzdOUrfnXcgX6vx792Q8YAY-HR9foHk4VYyQ> <xmx:k3TBXa7dXilScgfRy2Doopu0wiZazq_QaP-foW9iv9OL_7ZK5YOQRg> <xmx:lXTBXWsCCxF6IiqUHcllYVcPqLxh3ItqYYwo8bg0IXhK2WVgsG2IxQ> Received: from xps.localnet (200.251.23.93.rev.sfr.net [93.23.251.200]) by mail.messagingengine.com (Postfix) with ESMTPA id 222C380069; Tue, 5 Nov 2019 08:09:35 -0500 (EST) From: Thomas Monjalon <thomas@monjalon.net> To: Andrew Rybchenko <arybchenko@solarflare.com> Cc: Dekel Peled <dekelp@mellanox.com>, john.mcnamara@intel.com, marko.kovacevic@intel.com, nhorman@tuxdriver.com, ajit.khaparde@broadcom.com, somnath.kotur@broadcom.com, anatoly.burakov@intel.com, xuanziyang2@huawei.com, cloud.wangxiaoyun@huawei.com, zhouguoyang@huawei.com, wenzhuo.lu@intel.com, konstantin.ananyev@intel.com, matan@mellanox.com, shahafs@mellanox.com, viacheslavo@mellanox.com, rmody@marvell.com, shshaikh@marvell.com, maxime.coquelin@redhat.com, tiwei.bie@intel.com, zhihong.wang@intel.com, yongwang@vmware.com, ferruh.yigit@intel.com, jingjing.wu@intel.com, bernard.iremonger@intel.com, dev@dpdk.org Date: Tue, 05 Nov 2019 14:09:33 +0100 Message-ID: <1587538.ciIQpsefV0@xps> In-Reply-To: <974efb0f-c450-8f1c-f378-91b34a71f286@solarflare.com> References: <cover.1572943006.git.dekelp@mellanox.com> <325fd4151ea28e25a9c12ae028650fe3d6d022c0.1572943006.git.dekelp@mellanox.com> <974efb0f-c450-8f1c-f378-91b34a71f286@solarflare.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/3] ethdev: support API to set max LRO packet size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 05/11/2019 13:39, Andrew Rybchenko: > On 11/5/19 11:40 AM, Dekel Peled wrote: > > --- a/lib/librte_ethdev/rte_ethdev.c > > +++ b/lib/librte_ethdev/rte_ethdev.c > > +static inline int > > +rte_eth_check_lro_pkt_size(uint16_t port_id, uint32_t config_size, > > + uint32_t dev_info_size) > > As I understand Thomas prefers static functions without rte_eth_ prefix. > I think it is reasonable. Indeed, rte_ prefix should be reserved for public API.