From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f47.google.com (mail-wg0-f47.google.com [74.125.82.47])
 by dpdk.org (Postfix) with ESMTP id 159DB5955
 for <dev@dpdk.org>; Fri, 10 Jul 2015 01:00:38 +0200 (CEST)
Received: by wgck11 with SMTP id k11so235613599wgc.0
 for <dev@dpdk.org>; Thu, 09 Jul 2015 16:00:37 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=VpjAak0nP3rfgzQOF41dyEXsszG+xlOQ4Tgk4as8rvE=;
 b=NpYjz150zWSAi211HFxCqkJlxNZUkV47K9k2u0W7mFNvDSRoZSkX43kqBN700MyGgG
 Ysh4E96Dh8DIee43DDqkYNIH17JAWZAQToH2pH9u+kcpxw+j/6xR0yd8mHMndIBAF5uS
 zLcENYVsEPcEC8Y3InE0+FIfDBizKLuO6QvNTnTbHtAfi+Z3F+Aegm5x5VdII6P5gkVj
 Msii5wlW8ecsFq7HYmXitQr4ddw109tBVK+9EmRye6GXMJSSRVX1w8xhlMqNX/oyVh4t
 kWumMa2bBnVIcBQTU0ZD1AT3WuIh8hLD9x/rTIIoQIxrQ9lwduAX5XBwkghI53DADk38
 6T1A==
X-Gm-Message-State: ALoCoQk2pkrstPVhpwk+xzfQmarMWC1PIgpM84RX++ZS+qmTMEafXDUo9pkB9ST74WNdZuPHXbpw
X-Received: by 10.180.10.4 with SMTP id e4mr448307wib.82.1436482837878;
 Thu, 09 Jul 2015 16:00:37 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by smtp.gmail.com with ESMTPSA id o6sm210187wiz.16.2015.07.09.16.00.35
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 09 Jul 2015 16:00:36 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>, "Ananyev,
 Konstantin" <konstantin.ananyev@intel.com>
Date: Fri, 10 Jul 2015 00:59:29 +0200
Message-ID: <1588256.svH7QLA2p6@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <20150401113603.3591ad48@urahara>
References: <2601191342CEEE43887BDE71AB977258214074F6@irsmsx105.ger.corp.intel.com>
 <c8d4fd5c400c4beaa4577b8b1069fe04@BRMWP-EXMB12.corp.brocade.com>
 <20150401113603.3591ad48@urahara>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org, Stephen Hemminger <shemming@brocade.com>
Subject: Re: [dpdk-dev] [PATCH] ixgbe: do not include CRC in Tx byte count
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Jul 2015 23:00:38 -0000

2015-04-01 11:36, Stephen Hemminger:
> On Wed, 1 Apr 2015 07:45:02 +0000
> Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
> 
> > 2015-03-24 23:54, Ananyev, Konstantin:
> > > From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> > > > On Mon, 23 Mar 2015 16:45:44 +0000
> > > > "Ananyev, Konstantin" <konstantin.ananyev@intel.com> wrote:
> > > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of stephen@networkplumber.org
> > > > > > From: Stephen Hemminger <shemming@brocade.com>
> > > > > >
> > > > > > The ixgbe driver was including CRC in the transmit packet byte
> > > > > > count, but not for packets received.
> > > > > > This was notice when forwarding and
> > > > > > the number of bytes received was greater than the number of bytes transmitted
> > > > > > for the same number of packets. Make the driver behave like other
> > > > > > virtual devices and not include CRC in byte count. Use the same queue
> > > > > > counters already computed and used for Rx.
> > > > >
> > > > > About RX side stats - as I remember it depends to what value hw_stip_crc is set at configure().
> > > > > If hw_stip_crc==1, then, yes CRC bytes are not included into  QBRC value.
> > > > > I If hw_stip_crc==0, then CRC bytes are included into QBRC.
> > > > 
> > > > That is an additional bug!
> > > >   * CRC should never be included in the byte count.
> > > >     This is not how Linux or other drivers report byte count.
> > > 
> > > I don't have any strong opinion here...
> > > For me any method (with or without CRC) of counting bytes are ok, as long as this method is identical across all PMDs we support.
> > > Which makes we wonder, what approach other PMDs use? 
> > > 
> > > > 
> > > >   * the byte count must be symmetrical Rx == Tx
> > > > 
> > > > The Brocade router always set strip_crc to 1. So did not see the additional bug
> > > > of CRC being included in byte count.
> > > 
> > > Are you going to submit v2, to make Rx==Tx for both cases?
> > 
> > Any conclusion?
> > Without update, this patch is going to be dropped.
> 
> I was hoping Intel would maintain their drivers and fix the issue.
> Don't have resources to do it across all configurations and hardware,
> my bet is that this is broken on i40e, igb, e1000 as well.

Maybe that it will be properly fixed one day by someone.
Current patch is dropped.