From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) by dpdk.org (Postfix) with ESMTP id 02C72B0A3 for ; Wed, 16 Apr 2014 13:37:54 +0200 (CEST) Received: by mail-wi0-f181.google.com with SMTP id hm4so1216405wib.2 for ; Wed, 16 Apr 2014 04:37:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=qnKRABISJhKUPXDHtSs3ya27NYrOlwiCZFdkP66Byjs=; b=MxiWYjVV1SwkVbXWtp/ke2rstFTfMTxGiqSPuAIlY9aXVygph5sEWrkLXGttd0MFbF yBqV5IzTve6hzksCi4A+fox7UlJwW3Wip2VwX/YZSdg70h342aBWQM3/CtKDsFoPkBWO huYZ/T+Tde52/XbObNKydZoknvv873MghNLqwg8XYMf4IVg0nFR0am4kCOpyILlJ6l7Y 97C2pEzSaPpcttq1ygIx/8HlTSWVCNQJ2qfzPEHn1UQPqBbKjCgqiZ6DhAboQCcaPoZt QyQt/7t7v0RQR1CfmCVM2akUFCWzhjjkhHv1DILKp9eUUfyyN5LXz6iiYU5l8aXKeo4Y vYSg== X-Gm-Message-State: ALoCoQkXAYKAbX/GZrIfEKY9/RVb2Yy9OP4CMqeVqeSoFp59OEN8ab6VvUUDGuWSkLb08+2WWjqy X-Received: by 10.194.6.106 with SMTP id z10mr6460176wjz.1.1397648275318; Wed, 16 Apr 2014 04:37:55 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id v6sm35474909wif.0.2014.04.16.04.37.53 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Apr 2014 04:37:54 -0700 (PDT) From: Thomas Monjalon To: Neil Horman Date: Wed, 16 Apr 2014 13:37:54 +0200 Message-ID: <15883153.SaBPBKjheF@xps13> Organization: 6WIND User-Agent: KMail/4.12.4 (Linux/3.14.1-1-ARCH; KDE/4.12.4; x86_64; ; ) In-Reply-To: <20140416110018.GB26829@hmsreliant.think-freely.org> References: <1397585169-14537-1-git-send-email-nhorman@tuxdriver.com> <4354806.0Vn32RcRuD@xps13> <20140416110018.GB26829@hmsreliant.think-freely.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 01/15] makefiles: Fixed -share command line option error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Apr 2014 11:37:55 -0000 2014-04-16 07:00, Neil Horman: > On Wed, Apr 16, 2014 at 11:22:35AM +0200, Thomas Monjalon wrote: > > Hi, > > > > 2014-04-15 14:05, Neil Horman: > > > The shared libraries built with the current makefile set produce static > > > libraries rather than actual shared objects. This is due to several > > > missing options that are required to correctly build shared objects > > > using ld, as well as a mis-specified -share option (which should be > > > -shared). Switching to the use of CC rather than LD and fixing the > > > -shared option corrects these problems and builds the DSOs correctly. > > > > > > Signed-off-by: Neil Horman > > > > Thanks for fixing -shared option. > > > > Regarding switch to CC linking, please have a look at LINK_USING_CC > > option. > > Maybe you should use it for rte.lib.mk and rte.sharelib.mk. > > Yeah, I can do that. Would you like the whole series reposted, or just the > specific patch? Just sending this patch should be enough. Thanks -- Thomas