DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/octeontx2: offload bad L4 checksum detection
@ 2020-05-01  9:53 agupta3
  2020-05-04  7:59 ` Jerin Jacob
  0 siblings, 1 reply; 2+ messages in thread
From: agupta3 @ 2020-05-01  9:53 UTC (permalink / raw)
  To: Jerin Jacob, Nithin Dabilpuram, Kiran Kumar K; +Cc: dev, Amit Gupta

From: Amit Gupta <agupta3@marvell.com>

On detecting outer L4 checksum as bad, both outer and
inner checksums are marked as bad. No need to explicitly
check inner L4 checksum in this case.

Outer L4 UDP checksum error => PKT_RX_OUTER_L4_CKSUM_BAD
and PKT_RX_L4_CKSUM_BAD

Inner L4 UDP checksum error => PKT_RX_L4_CKSUM_BAD

Fixes: 41fe7a3a11fd ("net/octeontx2: offload bad L2/L3/L4 UDP lengths detection")

Signed-off-by: Amit Gupta <agupta3@marvell.com>
---
 drivers/net/octeontx2/otx2_lookup.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/octeontx2/otx2_lookup.c b/drivers/net/octeontx2/otx2_lookup.c
index 9dcfc75..10944bc 100644
--- a/drivers/net/octeontx2/otx2_lookup.c
+++ b/drivers/net/octeontx2/otx2_lookup.c
@@ -301,6 +301,7 @@
 			    errcode == NIX_RX_PERRCODE_OL4_LEN ||
 			    errcode == NIX_RX_PERRCODE_OL4_PORT) {
 				val |= PKT_RX_IP_CKSUM_GOOD;
+				val |= PKT_RX_L4_CKSUM_BAD;
 				val |= PKT_RX_OUTER_L4_CKSUM_BAD;
 			} else if (errcode == NIX_RX_PERRCODE_IL4_CHK ||
 				   errcode == NIX_RX_PERRCODE_IL4_LEN ||
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] net/octeontx2: offload bad L4 checksum detection
  2020-05-01  9:53 [dpdk-dev] [PATCH] net/octeontx2: offload bad L4 checksum detection agupta3
@ 2020-05-04  7:59 ` Jerin Jacob
  0 siblings, 0 replies; 2+ messages in thread
From: Jerin Jacob @ 2020-05-04  7:59 UTC (permalink / raw)
  To: agupta3; +Cc: Jerin Jacob, Nithin Dabilpuram, Kiran Kumar K, dpdk-dev

On Fri, May 1, 2020 at 3:23 PM <agupta3@marvell.com> wrote:
>
> From: Amit Gupta <agupta3@marvell.com>
>
> On detecting outer L4 checksum as bad, both outer and
> inner checksums are marked as bad. No need to explicitly
> check inner L4 checksum in this case.
>
> Outer L4 UDP checksum error => PKT_RX_OUTER_L4_CKSUM_BAD
> and PKT_RX_L4_CKSUM_BAD
>
> Inner L4 UDP checksum error => PKT_RX_L4_CKSUM_BAD
>
> Fixes: 41fe7a3a11fd ("net/octeontx2: offload bad L2/L3/L4 UDP lengths detection")
>
> Signed-off-by: Amit Gupta <agupta3@marvell.com>

Changed the subject to: net/octeontx2: fix offload bad L4 checksum detection

Acked-by: Jerin Jacob <jerinj@marvell.com>

Applied to dpdk-next-net-mrvl/master. Thanks




> ---
>  drivers/net/octeontx2/otx2_lookup.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/octeontx2/otx2_lookup.c b/drivers/net/octeontx2/otx2_lookup.c
> index 9dcfc75..10944bc 100644
> --- a/drivers/net/octeontx2/otx2_lookup.c
> +++ b/drivers/net/octeontx2/otx2_lookup.c
> @@ -301,6 +301,7 @@
>                             errcode == NIX_RX_PERRCODE_OL4_LEN ||
>                             errcode == NIX_RX_PERRCODE_OL4_PORT) {
>                                 val |= PKT_RX_IP_CKSUM_GOOD;
> +                               val |= PKT_RX_L4_CKSUM_BAD;
>                                 val |= PKT_RX_OUTER_L4_CKSUM_BAD;
>                         } else if (errcode == NIX_RX_PERRCODE_IL4_CHK ||
>                                    errcode == NIX_RX_PERRCODE_IL4_LEN ||
> --
> 1.8.3.1
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-05-04  8:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-01  9:53 [dpdk-dev] [PATCH] net/octeontx2: offload bad L4 checksum detection agupta3
2020-05-04  7:59 ` Jerin Jacob

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git