From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f48.google.com (mail-wg0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 7B1526895 for ; Thu, 22 May 2014 14:34:28 +0200 (CEST) Received: by mail-wg0-f48.google.com with SMTP id b13so3265969wgh.31 for ; Thu, 22 May 2014 05:34:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=+lU2dpc/S0KVuYulAzK6cLk1xrgQ+88lQYkCgnesOJY=; b=BTIDKD7i6RmMxvmzkE0F+HFhbnfEjcc6k3tKfABwFq7IZKCKvdy4oJ/YZdz7hvgpe3 3Yp6V4sqzjPzylvRrHcGMDvhQbHIACUw+/nQgUMh/5RdGgObNr8agTqTUILVBh5FKN4u bJKkS2YwrCsFGd2EYmp1JQfjZJsTuSk5uyo/Q82wsTtbv/tVQKzGphloG6tLpN3WN20Z 8ViHeBuHFe2uGySZc0TqDZ0YToHtHFDMFktzt+6djFJoIJSpXxzZLxOGU+CnsohJzj4B As1DRH0xZyQ2FbqF7YYugxmrCkJk1MRNfauDvY14HsBUxMXfFWL4PGliF5TA0YkbxAD2 tacA== X-Gm-Message-State: ALoCoQmKimNXjHWlaqYZq8EeuXfYgI4+QGieyIyi4s5AjLMjtYJjrpEB6epDx77Tv+m8YtA2soTP X-Received: by 10.194.81.164 with SMTP id b4mr50055582wjy.2.1400762078020; Thu, 22 May 2014 05:34:38 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id r15sm7760852wiw.17.2014.05.22.05.34.36 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 May 2014 05:34:37 -0700 (PDT) From: Thomas Monjalon To: Anatoly Burakov Date: Thu, 22 May 2014 14:34:33 +0200 Message-ID: <1589072.KAuytnYNqt@xps13> Organization: 6WIND User-Agent: KMail/4.13 (Linux/3.14.4-1-ARCH; KDE/4.13.0; x86_64; ; ) In-Reply-To: <1400514709-24087-11-git-send-email-anatoly.burakov@intel.com> References: <1400514709-24087-11-git-send-email-anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 10/16] Added support for selecting VFIO interrupt type from EAL command-line X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 May 2014 12:34:28 -0000 2014-05-19 16:51, Anatoly Burakov: > Unlike igb_uio, VFIO interrupt type is not set by kernel module > parameters but is set up via ioctl() calls at runtime. This warrants > a new EAL command-line parameter. It will have no effect if VFIO is > not compiled, but will set VFIO interrupt type to either "legacy" or > "msix" if VFIO support is compiled. Note that VFIO initialization will > fail if the interrupt type selected is not supported by the system. > > Signed-off-by: Anatoly Burakov > + } > else if (!strcmp(lgopts[option_index].name, OPT_CREATE_UIO_DEV)) another code style issue reported by checkpatch.pl ;) But it should be fixed by removing this code as Stephen suggests. -- Thomas