DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] doc: add limitation for L3fwd-power app
@ 2016-11-04 12:48 Pablo de Lara
  2016-11-04 13:04 ` Mcnamara, John
  2016-11-04 17:00 ` Thomas Monjalon
  0 siblings, 2 replies; 5+ messages in thread
From: Pablo de Lara @ 2016-11-04 12:48 UTC (permalink / raw)
  To: dev; +Cc: Pablo de Lara

L3fwd-power app needs vector mode to be disabled in order to work
properly. The app used to work previously, because it was using
Rx scalar function, but now it uses vector function.

Vector mode needs to be disabled to make the app works,
which has been documented in release notes.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 doc/guides/rel_notes/release_16_11.rst | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/doc/guides/rel_notes/release_16_11.rst b/doc/guides/rel_notes/release_16_11.rst
index aa0c09a..cb4ec97 100644
--- a/doc/guides/rel_notes/release_16_11.rst
+++ b/doc/guides/rel_notes/release_16_11.rst
@@ -178,6 +178,17 @@ Known Issues
 
    This section is a comment. Make sure to start the actual text at the margin.
 
+* **L3fwd-power app does not work properly when Rx vector is enabled.**
+
+  Using some drivers with vector enabled, makes L3fwd-power app not work
+  properly, since the queue monitoring works differently when using
+  scalar compared to vector, making the frequency scaling not to work correctly.
+  In addition, L3fwd-power requires the mbuf to have correct packet type,
+  but in some drivers, the vector mode must be disabled for this.
+
+  Therefore, in order to use L3fwd-power, vector mode should be disabled
+  from the config file.
+
 
 API Changes
 -----------
-- 
2.7.4

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: add limitation for L3fwd-power app
  2016-11-04 12:48 [dpdk-dev] [PATCH] doc: add limitation for L3fwd-power app Pablo de Lara
@ 2016-11-04 13:04 ` Mcnamara, John
  2016-11-07 21:06   ` Thomas Monjalon
  2016-11-04 17:00 ` Thomas Monjalon
  1 sibling, 1 reply; 5+ messages in thread
From: Mcnamara, John @ 2016-11-04 13:04 UTC (permalink / raw)
  To: De Lara Guarch, Pablo, dev; +Cc: De Lara Guarch, Pablo



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> Sent: Friday, November 4, 2016 12:48 PM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [dpdk-dev] [PATCH] doc: add limitation for L3fwd-power app
> 
> L3fwd-power app needs vector mode to be disabled in order to work
> properly. The app used to work previously, because it was using Rx scalar
> function, but now it uses vector function.
> 
> Vector mode needs to be disabled to make the app works, which has been
> documented in release notes.
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Acked-by: John McNamara <john.mcnamara@intel.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: add limitation for L3fwd-power app
  2016-11-04 12:48 [dpdk-dev] [PATCH] doc: add limitation for L3fwd-power app Pablo de Lara
  2016-11-04 13:04 ` Mcnamara, John
@ 2016-11-04 17:00 ` Thomas Monjalon
  2016-11-04 18:27   ` De Lara Guarch, Pablo
  1 sibling, 1 reply; 5+ messages in thread
From: Thomas Monjalon @ 2016-11-04 17:00 UTC (permalink / raw)
  To: Pablo de Lara; +Cc: dev

2016-11-04 12:48, Pablo de Lara:
> L3fwd-power requires the mbuf to have correct packet type,
> but in some drivers, the vector mode must be disabled for this.

This is a severe bug.
We must really fix packet type handling to have a constant support
whatever the driver or options.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: add limitation for L3fwd-power app
  2016-11-04 17:00 ` Thomas Monjalon
@ 2016-11-04 18:27   ` De Lara Guarch, Pablo
  0 siblings, 0 replies; 5+ messages in thread
From: De Lara Guarch, Pablo @ 2016-11-04 18:27 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev

Hi Thomas,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Friday, November 04, 2016 5:00 PM
> To: De Lara Guarch, Pablo
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] doc: add limitation for L3fwd-power app
> 
> 2016-11-04 12:48, Pablo de Lara:
> > L3fwd-power requires the mbuf to have correct packet type,
> > but in some drivers, the vector mode must be disabled for this.
> 
> This is a severe bug.
> We must really fix packet type handling to have a constant support
> whatever the driver or options.

This is already documented in previous release (2.2).
Actually, the main problem for L3fwd-power app is not the packet type,
but the descriptor_done for the Rx vector function, that works differently
compared to the scalar function.

Thanks,
Pablo

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: add limitation for L3fwd-power app
  2016-11-04 13:04 ` Mcnamara, John
@ 2016-11-07 21:06   ` Thomas Monjalon
  0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2016-11-07 21:06 UTC (permalink / raw)
  To: De Lara Guarch, Pablo; +Cc: dev, Mcnamara, John

> > L3fwd-power app needs vector mode to be disabled in order to work
> > properly. The app used to work previously, because it was using Rx scalar
> > function, but now it uses vector function.
> > 
> > Vector mode needs to be disabled to make the app works, which has been
> > documented in release notes.
> > 
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> 
> Acked-by: John McNamara <john.mcnamara@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2016-11-07 21:07 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-04 12:48 [dpdk-dev] [PATCH] doc: add limitation for L3fwd-power app Pablo de Lara
2016-11-04 13:04 ` Mcnamara, John
2016-11-07 21:06   ` Thomas Monjalon
2016-11-04 17:00 ` Thomas Monjalon
2016-11-04 18:27   ` De Lara Guarch, Pablo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).