From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EC3C9A04A2; Tue, 12 May 2020 14:22:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B54671BFE3; Tue, 12 May 2020 14:22:15 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2052.outbound.protection.outlook.com [40.107.20.52]) by dpdk.org (Postfix) with ESMTP id B71FA1BF95 for ; Tue, 12 May 2020 14:22:13 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RJpVM8ak1V5tARcA3+DVoaWfJ62fFSAjGFHTqwmfOvRO23hEa1oYLUPFpW+GyKQwW0SwNfOtFNTwKLtVlb8uoW3S4S5TtSkTq5mxDRZUDAB75r1dOaM6AVp6GS9K+7dLHJKsj8CnUHyVF14RaCv3/FH9nIJdrip+93jIWN11lYmhelrJSD7s2fw0czg6sjunQMQp2SJqrV1PBpYXBP4Od7KKR9U30rgZACZ+WHquVskvmA8JyrYOKf+FyxTYQrHq9ZEYE5ok7qwG07dsR8S1BoPTMbWlrgF4G/OWRRBHv1OU1G8FO/J3nzjDZV9/+LCx2/41GP3nMEIbkjuNDppgmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NaQpfBRqG2fzVV4Cwib4nn6vmFRqNSyfmyx32nCjwHY=; b=H8C4YekRD6K2lqZ5xUMtpjoA4FPtSfmg775DyH1UI9gszJ1aInq/uLwb/5FUAw5otmg3mOGTNVkYduHKzEiwyGSqZbFADhIa6RdjvC5oXXJLBf7g1KLeCvQD76Y2NrmEjq9j0pyUJSjfJnLLMW6VV70E5DIiqcoyAD9jDiJe5U8sdPKifTK9R6DRSqP5TI4T+G0CRSbpjJTlJE5NxjVPV13bjnhjJ4iVCHoEMxoffPljZh/OG8sKtbYDccvrGHIa8AoP4ebHbpvT1JtmluurXuCXJ4Cdv4JEUx+kSCcl78+q1i3l/6cQESkEbZ171ElJgHN4pNbZgZQcSVm3RNm+VQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NaQpfBRqG2fzVV4Cwib4nn6vmFRqNSyfmyx32nCjwHY=; b=dKkq9sPkN9vvgr0hPYtkXZ1qDAfzrn6Yj7V5wbSpO4kHZXHl+4rSmnBqae0fnYJs8/MvjdRk7LeyZgJv30HLL8BgEDya7VyAB/9/PqSnim+4CNjri+/V67phnbVM9/OkknSnefV8SUdSLsI8SPxcHv+3GIyyzbux85yWll28HoA= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=mellanox.com; Received: from AM0PR0502MB3874.eurprd05.prod.outlook.com (2603:10a6:208:1a::29) by AM0PR0502MB3844.eurprd05.prod.outlook.com (2603:10a6:208:20::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.27; Tue, 12 May 2020 12:22:12 +0000 Received: from AM0PR0502MB3874.eurprd05.prod.outlook.com ([fe80::2cea:8f0a:cb2f:2a85]) by AM0PR0502MB3874.eurprd05.prod.outlook.com ([fe80::2cea:8f0a:cb2f:2a85%6]) with mapi id 15.20.2979.033; Tue, 12 May 2020 12:22:12 +0000 From: Shiri Kuzin To: dev@dpdk.org Cc: matan@mellanox.com, viacheslavo@mellanox.com Date: Tue, 12 May 2020 15:21:44 +0300 Message-Id: <1589286106-23411-2-git-send-email-shirik@mellanox.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1589286106-23411-1-git-send-email-shirik@mellanox.com> References: <1589286106-23411-1-git-send-email-shirik@mellanox.com> Content-Type: text/plain X-ClientProxiedBy: AM3PR07CA0138.eurprd07.prod.outlook.com (2603:10a6:207:8::24) To AM0PR0502MB3874.eurprd05.prod.outlook.com (2603:10a6:208:1a::29) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from mellanox.com (94.188.199.18) by AM3PR07CA0138.eurprd07.prod.outlook.com (2603:10a6:207:8::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.12 via Frontend Transport; Tue, 12 May 2020 12:22:12 +0000 X-Mailer: git-send-email 1.8.3.1 X-Originating-IP: [94.188.199.18] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: b7323913-8324-4f76-d055-08d7f66f196c X-MS-TrafficTypeDiagnostic: AM0PR0502MB3844:|AM0PR0502MB3844: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-Forefront-PRVS: 0401647B7F X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZJXx9w80kimDFdV2DdG3VsAm1JNE0vh9ocCMeO5glYcAIFHLuIm9A3ZCHfPpkQP+BtaP3kgoP8uPboAwRPa7PMwsUTBhYVHQY5gxUDBW/xnbu3q0eEzDm/zCjx3zMSr6EwMgFQz9Idsh2IT23BLAASabDGfvnQYyIo127bVUP0Ud95wl4byIt6sVuLPCz9MZ2yP75dYNV7izpqFm77r6cWsjsl3T+orV7Z1+tjHWw3yXXTAc9KGbd6Kzgtugxuz1nW3W2Uke56XzQEAgdFISp93EEuA5/ETtoy2qx15NjvCttv+4sWeqSjyo5AgbMQrlZehxpyLPjY+jRy/5tydfwH3o/qlxDfAc4bMAtFcpIz1rjF8J/AHAyRnzNT6tTWiebbFBPg+8e7/7F4Ybh3LHJQ8iRS+KlcWZcLX7/fUw1AdHeAxfVfbGrQ/IDxBDohTQwLAA9VdRB6hx7zOkOslTy6n9bcsqQbKwSWF9Hu78kjRnXRHc4/U4yMkc6sCf38Lp2LLlGtWtFRCpcagfgn3yhg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR0502MB3874.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(346002)(39860400002)(376002)(136003)(366004)(396003)(33430700001)(8936002)(4326008)(55016002)(86362001)(107886003)(5660300002)(956004)(316002)(66946007)(66556008)(66476007)(2616005)(2906002)(52116002)(186003)(26005)(7696005)(16526019)(33440700001)(8886007)(6666004)(6916009)(8676002)(478600001)(36756003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: cUs3opevHPf86K54lFVt+uHvpm/+Cn9gIDwtp9ZT2C4F24rR6L2qsHxcw3O8IzCWBmfdANjwOrAyBsybdwyhGf1LH7SIbuUJGQiQohPDkkQFITddvlw/W95Wtew3vbd7mQu+PstHFZ7QWBdVkyv5lujU+p3/mcJ7nOkKq/FoUAcdwZsMs/zf/DgDtdsZXj2jwjP4sK2mI88k+lffP68QkiAiCOgu3DfNxV71lwc37QrrsKHAollQi6OpG2b5HKRnv2xI02lORZGuDeAHurK6bkHoYgg3d6+GvuPbtLlRWcOz4QjAmyhz/446CuWOWEd3ju7OHZcAJr4VSimjz3c6WUtyNhgNknvs2omXHpXwvH9F/hUxsoBQg3mBdRO1Us2M4uc7sA6qxKLnkmTRwRcBOq1VQSeF9WiBvHPvQQtaQlfBrytrdJOVtFau3CkOoYg6t0Tt8tpZm6l/jOPjcz+ScnlGaj6CLF8v5eARisVfrlI= X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: b7323913-8324-4f76-d055-08d7f66f196c X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2020 12:22:12.6717 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Y+Ctjj1o5UoQJC5JaN1b2N3TFLgnycZgwurbu2IlvTNz5bhqzSoZQyT4F4XyjCCFfMD3btJRHe0VlWUG3B2aIA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3844 Subject: [dpdk-dev] [PATCH 1/3] common/mlx5: fix relaxed ordering support detection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Relaxed ordering is a PCI optimization that allows reordering of reads/writes in order to improve performance. In order to enable this optimization only when relaxed ordering is supported, it is checked if IBV_ACCESS_RELAXED_ORDERING is defined in verbs.h. Since IBV_ACCESS_RELAXED_ORDERING is an enum and not defined relaxed ordering wasn't enabled even when supported. This issue is fixed by using AUTOCONF to check if relaxed ordering is supported and disabling only if it isn't. Fixes: 53ac93f71ad1 ("net/mlx5: create relaxed ordering memory regions") Signed-off-by: Shiri Kuzin --- drivers/common/mlx5/Makefile | 5 +++++ drivers/common/mlx5/meson.build | 2 ++ drivers/common/mlx5/mlx5_glue.h | 2 +- 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/common/mlx5/Makefile b/drivers/common/mlx5/Makefile index 8b663ef..0d8cc1b 100644 --- a/drivers/common/mlx5/Makefile +++ b/drivers/common/mlx5/Makefile @@ -68,6 +68,11 @@ mlx5_autoconf.h.new: FORCE mlx5_autoconf.h.new: $(RTE_SDK)/buildtools/auto-config-h.sh $Q $(RM) -f -- '$@' $Q sh -- '$<' '$@' \ + HAVE_IBV_RELAXED_ORDERING \ + infiniband/verbs.h \ + enum IBV_ACCESS_RELAXED_ORDERING \ + $(AUTOCONF_OUTPUT) + $Q sh -- '$<' '$@' \ HAVE_IBV_DEVICE_STRIDING_RQ_SUPPORT \ infiniband/mlx5dv.h \ enum MLX5DV_CQE_RES_FORMAT_CSUM_STRIDX \ diff --git a/drivers/common/mlx5/meson.build b/drivers/common/mlx5/meson.build index 165aa25..5a802ba 100644 --- a/drivers/common/mlx5/meson.build +++ b/drivers/common/mlx5/meson.build @@ -94,6 +94,8 @@ has_member_args = [ # [ "MACRO to define if found", "header for the search", # "symbol to search" ] has_sym_args = [ + [ 'HAVE_IBV_RELAXED_ORDERING', 'infiniband/verbs.h', + 'IBV_ACCESS_RELAXED_ORDERING ' ], [ 'HAVE_IBV_DEVICE_STRIDING_RQ_SUPPORT', 'infiniband/mlx5dv.h', 'MLX5DV_CQE_RES_FORMAT_CSUM_STRIDX' ], [ 'HAVE_IBV_DEVICE_TUNNEL_SUPPORT', 'infiniband/mlx5dv.h', diff --git a/drivers/common/mlx5/mlx5_glue.h b/drivers/common/mlx5/mlx5_glue.h index 184c410..81d6a22 100644 --- a/drivers/common/mlx5/mlx5_glue.h +++ b/drivers/common/mlx5/mlx5_glue.h @@ -98,7 +98,7 @@ uint64_t comp_mask; }; #endif -#ifndef IBV_ACCESS_RELAXED_ORDERING +#ifndef HAVE_IBV_RELAXED_ORDERING #define IBV_ACCESS_RELAXED_ORDERING 0 #endif -- 1.8.3.1