From: Stephen Hemminger <stephen@networkplumber.org>
To: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] pci: properly parse 32-bit domain numbers
Date: Tue, 12 May 2020 11:16:28 -0700 [thread overview]
Message-ID: <1589307388.25513.0@networkplumber.org> (raw)
In-Reply-To: <20200512133057.106374-1-dariusz.stojaczyk@intel.com>
On Tue, May 12, 2020 at 3:30 pm, Darek Stojaczyk
<dariusz.stojaczyk@intel.com> wrote:
> The parsing code was bailing on domains greater than UINT16_MAX,
> but domain numbers like that are still valid and present on some
> systems.
> One example is Intel VMD (Volume Management Device), which acts
> somewhat
> as a software-managed PCI switch and its upstream linux driver assigns
> all downstream devices a PCI domain of 0x10000.
>
> Parsing a BDF like 10000:01:00.0 was failing before. To fix it,
> increase
> the upper limit of domain number to UINT32_MAX. This matches the size
> of
> struct rte_pci_addr->domain (uint32).
>
> Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com
> <mailto:dariusz.stojaczyk@intel.com>>
> ---
> lib/librte_pci/rte_pci.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_pci/rte_pci.c b/lib/librte_pci/rte_pci.c
> index d1ab6b414d..ad2cdfebb2 100644
> --- a/lib/librte_pci/rte_pci.c
> +++ b/lib/librte_pci/rte_pci.c
> @@ -72,9 +72,9 @@ pci_dbdf_parse(const char *input, struct
> rte_pci_addr *dev_addr)
>
> errno = 0;
> val = strtoul(in, &end, 16);
> - if (errno != 0 || end[0] != ':' || val > UINT16_MAX)
> + if (errno != 0 || end[0] != ':' || val > UINT32_MAX)
> return -EINVAL;
> - dev_addr->domain = (uint16_t)val;
> + dev_addr->domain = (uint32_t)val;
> in = end + 1;
> in = get_u8_pciaddr_field(in, &dev_addr->bus, ':');
> if (in == NULL)
> --
> 2.17.1
Agree this came up before on Hyper-V as well. It meant fixing libpci.
Not sure the cast of val is necessary, other than an attempt to silence
some static checker
about implicit type conversion causing loss of precision.
>
next prev parent reply other threads:[~2020-05-12 18:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 13:30 Darek Stojaczyk
2020-05-12 15:08 ` Burakov, Anatoly
2020-05-12 18:16 ` Stephen Hemminger [this message]
2020-05-13 9:04 ` Gaëtan Rivet
2020-05-13 12:20 ` Stojaczyk, Dariusz
2020-05-19 9:15 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1589307388.25513.0@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dariusz.stojaczyk@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).