From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas.monjalon@6wind.com> Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com [209.85.212.175]) by dpdk.org (Postfix) with ESMTP id 4CB25804B for <dev@dpdk.org>; Wed, 17 Dec 2014 11:04:52 +0100 (CET) Received: by mail-wi0-f175.google.com with SMTP id l15so15133323wiw.2 for <dev@dpdk.org>; Wed, 17 Dec 2014 02:04:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=iCMZhjjK8u8p+3MztFX35SvxhYK+9l5MaVDgxeyej4A=; b=bUg6Acdx/PibhGTanyV/HyyRwQfBT0I2mfixykC43wvGRvH+bYXwjzz0dn2Rx9lE0l 17L/+3qtLeHuiddKuvoQoML2zBrwUUsdH6WrYGumnrgLeOsSyyfBkp8hdhTlu9Xj6mQU E4JVDb/wSS5wsDeEDLMzoLvlwTNkUg3jLzlHaLftLaK/ZJe85o3pQncWbd3SHN1tXoeU khGr9qfXNeMoNI6wuEkTS+D1H2w7gQD1URRo9+cj9eY+5pwxdfCkQ0UVRJ6seRSBzKoL yKP92GilpGZeBJWksNQS3NXBVaXizknf7thCZG0rsdrmoFw0U4wjlhRJcVvKXmCoMUIa FVRg== X-Gm-Message-State: ALoCoQk6Xe7XrI4JkyHmXT4Uv55Fd5exVf3tq8t4AhWS7vsXThV2tUDoLjZygYv8uTeLaBYfOhml X-Received: by 10.194.80.193 with SMTP id t1mr69660274wjx.8.1418810691606; Wed, 17 Dec 2014 02:04:51 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id qd2sm5473080wic.19.2014.12.17.02.04.50 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 Dec 2014 02:04:50 -0800 (PST) From: Thomas Monjalon <thomas.monjalon@6wind.com> To: "Ouyang, Changchun" <changchun.ouyang@intel.com> Date: Wed, 17 Dec 2014 11:04:25 +0100 Message-ID: <1589451.jCIKiaz4qv@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <F52918179C57134FAEC9EA62FA2F96251194779C@shsmsx102.ccr.corp.intel.com> References: <1418357726-25141-1-git-send-email-changchun.ouyang@intel.com> <1785187.jrxsoh9Kkn@xps13> <F52918179C57134FAEC9EA62FA2F96251194779C@shsmsx102.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] examples/vhost: Fix vlan offload issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 17 Dec 2014 10:04:52 -0000 2014-12-17 00:51, Ouyang, Changchun: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2014-12-12 12:15, Ouyang Changchun: > > > The following commit break vm2vm hard mode test cases: > > > commit db4014f2b65cb31bf209cadd5bcec778ca137fe2 > > > Author: Huawei Xie <huawei.xie@intel.com> > > > Date: Thu Nov 13 06:34:07 2014 +0800 > > > examples/vhost: use factorized default Rx/Tx configuration > > > > > > Investigation show that it needs enabling vlan offload since it is > > > turn off by default, and Tx need it, especially when vm2vm is in hard mode. > > > > I missed something here. Where VLAN offload is disabled by default? > > Could you point the code, please? > > Inside the function ixgbe_dev_info_get() > The txq_flags is assigned value of "ETH_TXQ_FLAGS_MULTISEGS|ETH_TXQ_FLAGS_NOOFFLOADS", > The ETH_TXQ_FLAGS_NOOFFLOADS contain ETH_TXQ_FLAGS_NOVLANOFFL. > so VLAN offload is disabled. > > Do you think any incorrect in my original description? Yes. You say VLAN offload is turned off by default. But it's the case only for ixgbe, i40e and vmxnet3. -- Thomas