[dpdk-dev] [PATCH 0/6] improvements to OCTEON TX crypto PMDs

[dpdk-dev] [PATCH 0/6] improvements to OCTEON TX crypto PMDs

[Anoob Joseph]

This series adds multiple optimizations and improvements to OCTEON TX crypto PMDs
and OCTEON TX2 security support.

Ankur Dwivedi (2):
  crypto/octeontx2: enable non-byte aligned data feature
  crypto/octeontx: enable non-byte aligned data feature

Anoob Joseph (3):
  common/octeontx2: fix out of bounds access
  crypto/octeontx2: improve error handling in session configure
  crypto/octeontx: redesign sym sessionless code path

Tejasree Kondoj (1):
  net/octeontx2: increase max packet length for Inline IPsec Rx

 doc/guides/cryptodevs/features/octeontx.ini   |   1 +
 doc/guides/cryptodevs/features/octeontx2.ini  |   1 +
 drivers/common/cpt/cpt_ucode.h                |  75 ---------
 drivers/common/octeontx2/otx2_sec_idev.c      |   4 +-
 drivers/crypto/octeontx/otx_cryptodev_ops.c   | 210 ++++++++++++++------------
 drivers/crypto/octeontx2/otx2_cryptodev.c     |   1 +
 drivers/crypto/octeontx2/otx2_cryptodev_ops.c |  43 +++++-
 drivers/net/octeontx2/otx2_ethdev_sec.c       |   4 +-
 8 files changed, 160 insertions(+), 179 deletions(-)

-- 
2.7.4

[dpdk-dev] [PATCH 1/6] common/octeontx2: fix out of bounds access

[Anoob Joseph]

Coverity issue: 354230, 354231

Fixes: f44e71637755 ("net/octeontx2: add security session operations")
Fixes: 3fe4d07d1678 ("crypto/octeontx2: enable CPT to share QP with ethdev")

Signed-off-by: Anoob Joseph <anoobj@marvell.com>
---
 drivers/common/octeontx2/otx2_sec_idev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/common/octeontx2/otx2_sec_idev.c b/drivers/common/octeontx2/otx2_sec_idev.c
index 4e65ce2..6e9643c 100644
--- a/drivers/common/octeontx2/otx2_sec_idev.c
+++ b/drivers/common/octeontx2/otx2_sec_idev.c
@@ -55,7 +55,7 @@ otx2_sec_idev_tx_cpt_qp_add(uint16_t port_id, struct otx2_cpt_qp *qp)
 	struct otx2_sec_idev_cfg *cfg;
 	int i, ret;
 
-	if (qp == NULL || port_id > OTX2_MAX_INLINE_PORTS)
+	if (qp == NULL || port_id >= OTX2_MAX_INLINE_PORTS)
 		return -EINVAL;
 
 	cfg = &sec_cfg[port_id];
@@ -126,7 +126,7 @@ otx2_sec_idev_tx_cpt_qp_get(uint16_t port_id, struct otx2_cpt_qp **qp)
 	uint16_t index;
 	int i, ret;
 
-	if (port_id > OTX2_MAX_INLINE_PORTS || qp == NULL)
+	if (port_id >= OTX2_MAX_INLINE_PORTS || qp == NULL)
 		return -EINVAL;
 
 	cfg = &sec_cfg[port_id];
-- 
2.7.4

Re: [dpdk-dev] [PATCH 0/6] improvements to OCTEON TX crypto PMDs

[Anoob Joseph]

Hi Akhil,

> Hi Anoob,
> 
> This patch series is pretty late for the RC3, specially your last patch.
> However the patches looks good to me, I have applied them to dpdk-next-
> crypto with some modifications in the commit titles and descriptions.
> 
> Please send the fixes a bit earlier from next time.
> 

[Anoob] Sure. The rework of the test application etc mandated the changes in the PMD. I wanted to send one series with all the changes from our end (in the PMD) rather than sending multiple patches. Next time, will try to send before RC2. Hope that would do.

Thanks,
Anoob

Re: [dpdk-dev] [PATCH 0/6] improvements to OCTEON TX crypto PMDs

[Akhil Goyal]

Hi Anoob,

This patch series is pretty late for the RC3, specially your last patch.
However the patches looks good to me, I have applied them to dpdk-next-crypto
with some modifications in the commit titles and descriptions.

Please send the fixes a bit earlier from next time.

Regards,
Akhil
> 
> This series adds multiple optimizations and improvements to OCTEON TX crypto
> PMDs
> and OCTEON TX2 security support.
> 
> Ankur Dwivedi (2):
>   crypto/octeontx2: enable non-byte aligned data feature
>   crypto/octeontx: enable non-byte aligned data feature
> 
> Anoob Joseph (3):
>   common/octeontx2: fix out of bounds access
>   crypto/octeontx2: improve error handling in session configure
>   crypto/octeontx: redesign sym sessionless code path
> 
> Tejasree Kondoj (1):
>   net/octeontx2: increase max packet length for Inline IPsec Rx
> 
>  doc/guides/cryptodevs/features/octeontx.ini   |   1 +
>  doc/guides/cryptodevs/features/octeontx2.ini  |   1 +
>  drivers/common/cpt/cpt_ucode.h                |  75 ---------
>  drivers/common/octeontx2/otx2_sec_idev.c      |   4 +-
>  drivers/crypto/octeontx/otx_cryptodev_ops.c   | 210 ++++++++++++++-----------
> -
>  drivers/crypto/octeontx2/otx2_cryptodev.c     |   1 +
>  drivers/crypto/octeontx2/otx2_cryptodev_ops.c |  43 +++++-
>  drivers/net/octeontx2/otx2_ethdev_sec.c       |   4 +-
>  8 files changed, 160 insertions(+), 179 deletions(-)
> 
> --
> 2.7.4

[dpdk-dev] [PATCH 0/6] improvements to OCTEON TX crypto PMDs

[Anoob Joseph]

This series adds multiple optimizations and improvements to OCTEON TX crypto PMDs
and OCTEON TX2 security support.

Ankur Dwivedi (2):
  crypto/octeontx2: enable non-byte aligned data feature
  crypto/octeontx: enable non-byte aligned data feature

Anoob Joseph (3):
  common/octeontx2: fix out of bounds access
  crypto/octeontx2: improve error handling in session configure
  crypto/octeontx: redesign sym sessionless code path

Tejasree Kondoj (1):
  net/octeontx2: increase max packet length for Inline IPsec Rx

 doc/guides/cryptodevs/features/octeontx.ini   |   1 +
 doc/guides/cryptodevs/features/octeontx2.ini  |   1 +
 drivers/common/cpt/cpt_ucode.h                |  75 ---------
 drivers/common/octeontx2/otx2_sec_idev.c      |   4 +-
 drivers/crypto/octeontx/otx_cryptodev_ops.c   | 210 ++++++++++++++------------
 drivers/crypto/octeontx2/otx2_cryptodev.c     |   1 +
 drivers/crypto/octeontx2/otx2_cryptodev_ops.c |  43 +++++-
 drivers/net/octeontx2/otx2_ethdev_sec.c       |   4 +-
 8 files changed, 160 insertions(+), 179 deletions(-)

-- 
2.7.4