From: Yunjian Wang <wangyunjian@huawei.com> Fix memory leaks reported by Coverity. Fixes: e63b50162aa3 ("app/testpmd: clean metering and policing commands") Cc: stable@dpdk.org Signed-off-by: Yunjian Wang <wangyunjian@huawei.com> --- app/test-pmd/cmdline_mtr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/app/test-pmd/cmdline_mtr.c b/app/test-pmd/cmdline_mtr.c index caa7e9864..ee16244de 100644 --- a/app/test-pmd/cmdline_mtr.c +++ b/app/test-pmd/cmdline_mtr.c @@ -1262,6 +1262,7 @@ static void cmd_set_port_meter_policer_action_parsed(void *parsed_result, ret = rte_mtr_policer_actions_update(port_id, mtr_id, action_mask, actions, &error); if (ret != 0) { + free(actions); print_err_msg(&error); return; } -- 2.23.0
23/05/2020 13:21, wangyunjian: > From: Yunjian Wang <wangyunjian@huawei.com> > > Fix memory leaks reported by Coverity. Please add the Coverity ID with the syntax "Coverity issue:". > > Fixes: e63b50162aa3 ("app/testpmd: clean metering and policing commands") > Cc: stable@dpdk.org > > Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Monday, May 25, 2020 12:08 AM > To: wangyunjian <wangyunjian@huawei.com> > Cc: dev@dpdk.org; Lilijun (Jerry) <jerry.lilijun@huawei.com>; xudingke > <xudingke@huawei.com>; stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] test-pmd: fix memory leaks when mtr policer > actions update fails > > 23/05/2020 13:21, wangyunjian: > > From: Yunjian Wang <wangyunjian@huawei.com> > > > > Fix memory leaks reported by Coverity. > > Please add the Coverity ID with the syntax "Coverity issue:". This problem was found by Huawei internal Coverity. So I didn't add the Coverity ID. I will update the description to "This patch fixes the huawei internal coverity reported resource leak issue." in v2. Thanks Yunjian > > > > > Fixes: e63b50162aa3 ("app/testpmd: clean metering and policing > commands") > > Cc: stable@dpdk.org > > > > Signed-off-by: Yunjian Wang <wangyunjian@huawei.com> > >