DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] app/test/test_table_acl: fill missing field
@ 2016-04-01 15:40 Fan Zhang
  2016-04-01 21:00 ` Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Fan Zhang @ 2016-04-01 15:40 UTC (permalink / raw)
  To: dev

This patch fills the missing field of ipv4_5tuple structure in acl table
test.

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
 app/test/test_table_acl.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/app/test/test_table_acl.c b/app/test/test_table_acl.c
index b3bfda4..6ab0348 100644
--- a/app/test/test_table_acl.c
+++ b/app/test/test_table_acl.c
@@ -1,7 +1,7 @@
 /*-
  *   BSD LICENSE
  *
- *   Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
+ *   Copyright(c) 2010-2016 Intel Corporation. All rights reserved.
  *   All rights reserved.
  *
  *   Redistribution and use in source and binary forms, with or without
@@ -45,7 +45,9 @@
  **/
 
 struct ipv4_5tuple {
+	uint8_t  ttl;
 	uint8_t  proto;
+	uint16_t checksum;
 	uint32_t ip_src;
 	uint32_t ip_dst;
 	uint16_t port_src;
-- 
2.5.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] app/test/test_table_acl: fill missing field
  2016-04-01 15:40 [dpdk-dev] [PATCH] app/test/test_table_acl: fill missing field Fan Zhang
@ 2016-04-01 21:00 ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2016-04-01 21:00 UTC (permalink / raw)
  To: Fan Zhang; +Cc: dev

2016-04-01 16:40, Fan Zhang:
> This patch fills the missing field of ipv4_5tuple structure in acl table
> test.

I still don't understand why it is needed.

>  struct ipv4_5tuple {
> +	uint8_t  ttl;
>  	uint8_t  proto;
> +	uint16_t checksum;
>  	uint32_t ip_src;
>  	uint32_t ip_dst;
>  	uint16_t port_src;

Adding 2 fields to a 5-tuple makes it a 7-tuple.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-04-01 21:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-01 15:40 [dpdk-dev] [PATCH] app/test/test_table_acl: fill missing field Fan Zhang
2016-04-01 21:00 ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).