From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by dpdk.org (Postfix) with ESMTP id DE77C9A8E for ; Tue, 10 Mar 2015 14:29:45 +0100 (CET) Received: by wiwl15 with SMTP id l15so3027138wiw.0 for ; Tue, 10 Mar 2015 06:29:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=xUU02zvVbyYeLHwHtDtKjHY7rGVJovQRoq1pyF844qA=; b=IKHIU+ovhk3E83Q0t5Wi3fO/TCFIvY2KGgbUd1cakvveL+Vjxr9n8i12CT8Q3ptQ0Z YnDHPCfhTAW31hT4hsh6CaK9t6Xi3QPMV7RGdmOxC4uMeYIk7J355ICnYd5EiAugLX+k Dxg/X9eYQX7K0Fn/3swxHD3xDeK85Lc3n/w+4trRs8eKMSIfnSHknhpOw53tBTyzk8mf OyqqvTnJ1LxGYQmxiw3CQCCWnWu3sFd3M085X8sQrZK9BL3odNleO7cBwp1xv+w2G0XH lSjc11PpsgF2YWVTQV4ZTeCoVZvDjzyZhnN4JjYszqUaQURmW4xuvbZJmj0YMcbxtfGM Y7Vw== X-Gm-Message-State: ALoCoQnOyMOenPoNrL0zlal5hq2b0Wuty80X/qBSODS+SQhyo1sXiq7YV8qdmhPZooJQ7zzlioqe X-Received: by 10.180.104.33 with SMTP id gb1mr50066387wib.33.1425994185643; Tue, 10 Mar 2015 06:29:45 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id t9sm20284970wia.15.2015.03.10.06.29.44 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Mar 2015 06:29:44 -0700 (PDT) From: Thomas Monjalon To: Stephen Hemminger Date: Tue, 10 Mar 2015 14:29:11 +0100 Message-ID: <1590804.b4qbFBa696@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <8562501.9F7O0EyhDp@xps13> References: <20141227151300.7b62f5bf@urahara> <6701277.4xurLSZEjD@xps13> <8562501.9F7O0EyhDp@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [RFC] resolve conflict between net/ethernet.h and rte_ethdev.h X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Mar 2015 13:29:46 -0000 2015-03-05 00:16, Thomas Monjalon: > 2015-01-06 11:44, Thomas Monjalon: > > 2014-12-27 15:13, Stephen Hemminger: > > > This is a patch to address the conflict between > > > and the definitions in . It has two side effects > > > worth discussion: > > > 1. It forces inclusion of net/ethernet.h > > > 2. It has definition to deal with the differing structure elements > > > in the two versions of struct ether_addr. > > > > > > By doing this ether_ntoa and related functions can be used without > > > messing with prototypes. > > > > > > Alternative is more complex #ifdef magic like linux/libc-compat.h > > > > [...] > > > > > +#include > > > > [...] > > > > > +/* Deprecated definition to allow for compatiablity with net/ethernet.h */ > > > +#define addr_bytes ether_addr_octet > > > > This is defining a common identifier without prefix. > > So it will be forbidden to use addr_bytes as variable name. > > I understand you are trying to keep compatibility with both structures, > > but the drawback is really nasty. > > Is there another solution? Or at least, we could mark it as deprecated and > > remove it in release 2.1. > > ping > Any opinion? Hi Stephen, If, by any chance, you are willing to reply to this thread, maybe you would like to send a non-rfc patch with these 2 additions: - rename addr_bytes to ether_addr_octet everywhere - mark addr_bytes as deprecated in doc/guides/rel_notes/abi.rst